Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use babel > as prompt in babel-node #9695

Merged
merged 1 commit into from Jan 10, 2020
Merged

Use babel > as prompt in babel-node #9695

merged 1 commit into from Jan 10, 2020

Conversation

ZYSzys
Copy link
Contributor

@ZYSzys ZYSzys commented Mar 16, 2019 •
edited

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change? Maybe No
Minor: New Feature? Maybe yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In babel-node, use babel > as prompt instead of simple > (to show babel brand specially)

FYI, gatsby repl just did in this way :)
https://github.com/gatsbyjs/gatsby/blob/cfc5126ba604ceaaf561d51007d6b67d115106b3/packages/gatsby/src/commands/repl.js#L36

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10503/

@danez danez added the PR: Polish 💅 A type of pull request used for our changelog categories label Mar 19, 2019
JLHwung
JLHwung approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! By doing this we can also differentiate from Node.js REPL. For example user could start a Node.js REPL like this:

npx @babel/node

nicolo-ribaudo
nicolo-ribaudo approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this PR go in a patch release, or should it wait for a minor?

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Nov 12, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.0 milestone Nov 13, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 646409b into babel:master Jan 10, 2020
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
This was referenced Feb 22, 2020
Open
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Merged
Merged
Open
Open
Open
This was referenced Mar 22, 2020
Open
Open
Open
Open
Open
Open
This was referenced Mar 27, 2020
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 4, 2020
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
v7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZYSzys @babel-bot @JLHwung @nicolo-ribaudo @danez