Prevents exception on PnP #9951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you run |
|
@nicolo-ribaudo Just pushed the result of this command, but it seems to include a lot of changes. Is that expected? |
|
Ping? |
|
It looks that something went wrong and some test files have been deleted. Could you revert the last commit and run |
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
|
Merged as d7801c6. Thank you! |
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Jun 1, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PnP environments throw semantic errors when a dependency cannot be found (in this case, it's because
kexecisn't listed in@babel/node's dependency list, and thus it's not allowed to access it). This cause the error to be thrown instead of silently ignored.The real fix would be to use optional peer dependencies to list the
kexecpeer dependency, but at the moment I'm looking for an uncontroversial hotfix to ship asap.