Gulp babili #318
Merged
Gulp babili #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
commented
Dec 3, 2016
packages/gulp-babili/src/index.js
Outdated
|
|
||
| module.exports = gulpBabili; | ||
|
|
||
| function gulpBabili(_opts = {}) { |
There was a problem hiding this comment.
will change this and take 2 arguments instead for passing in custom babel, babili and comments
boopathi
commented
Dec 3, 2016
packages/gulp-babili/src/index.js
Outdated
|
|
||
| /* remove comments */ | ||
| shouldPrintComment(contents) { | ||
| return shouldPrintComment(contents, commentsRegex); |
There was a problem hiding this comment.
this is never called. I'm not sure why.
|
fuse-box that was just released uses gulp-uglify as well https://github.com/fuse-box/fuse-box/blob/461eeeeef5752e069b53de009554af7be145a499/gulpfile.js#L31 |
boopathi
commented
Jan 20, 2017
| }); | ||
| }); | ||
|
|
||
| xit("should remove comments by default except license and preserve", () => { |
There was a problem hiding this comment.
this test is disabled as it removes all comments by default.
boopathi
force-pushed
the
gulp-babili
branch
from
b7f798f
to
feed6a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: