Tweak simpify README #320
Tweak simpify README #320
Conversation
| else b(); | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Identation with code blocks seems to no work. Could you remove them ?
existentialism
force-pushed
the
docs-simplify
branch
from
6320550
to
d75e595
Compare
| @@ -2,9 +2,10 @@ | |||
|
|
|||
| This plugin will transform code in mainly two ways: | |||
|
|
|||
| 1. Reduce as much statements as possible into expressions | |||
| 1\. Reduce as much statements as possible into expressions | |||
There was a problem hiding this comment.
It's a temporary workaround to get the numbering correct and prevent indention since it causes all sorts of wonkiness with both the nested text and code block, currently:
There was a problem hiding this comment.
It looks like this is something that needs to be fixed on the website then.
There was a problem hiding this comment.
Hmm. It's not in the readme on github as well. Cool ... Then we can simply use unordered lists instead of ordered ... Numbering isn't important
There was a problem hiding this comment.
It's fine, can revert that until we get a more robust fix in place. Just note that this isn't isolated to just the website, the numbering is off on npm and GitHub) due to the code block.
There was a problem hiding this comment.
or even headings, maybe ? what do you think?
There was a problem hiding this comment.
this isn't isolated to just the website
Yeah. Noticed it just now. do you think making it a heading would be better ?
There was a problem hiding this comment.
Yeah, that's definitely another option... howabout:
> Simplifies code for minification by reducing statements into expressions and making expressions and uniform where possible.
## Example
### Reduce statement into expression:
**In**
// code example
**Out**
// code example
### Make expression as uniform as possible for better compressibility:
**In**
// code example
**Out**
// code example
dedbf05
to
1a982bd
Compare
|
@boopathi updated! /cc: @xtuc @geordidearns |
| @@ -1,10 +1,13 @@ | |||
| # babel-plugin-minify-simplify | |||
|
|
|||
| This plugin will transform code in mainly two ways: | |||
| > Simplifies code for minification by reducing statements into expressions and making expressions and uniform where possible. | |||
There was a problem hiding this comment.
- and making expressions and uniform
+ and making expressions uniform
existentialism
force-pushed
the
docs-simplify
branch
from
1a982bd
to
92e1014
Compare
There was a problem hiding this comment.
LGTM.
@xtuc @geordidearns. do you have any comments before I merge this ?
|
Nice work, LGTM 👍 |
Adds line break in between examples (babel/website#1029) and fixes numbering.