Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if_return - deopt when ref loses scope #408

Merged
merged 3 commits into from Feb 27, 2017
Merged

if_return - deopt when ref loses scope #408

merged 3 commits into from Feb 27, 2017

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented Feb 8, 2017

Adds a temporary fix for #420 - binding not found when the path is a variableDeclaration.

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Feb 8, 2017
@boopathi
Copy link
Member Author

boopathi commented Feb 8, 2017

The test fails because of padding issue.

@boopathi boopathi mentioned this pull request Feb 11, 2017
@boopathi
Copy link
Member Author

boopathi commented Feb 18, 2017

The diff for breaking test cases -

# test1
@@ -1,6 +1,6 @@
  function x() {
    if (bar) {
-    var x = foo;
-    if (foo && y) throw y;
-  }
+      var x = foo;
+      if (foo && y) throw y;
+    }
  }

# test 2
@@ -2,8 +2,8 @@
    function bar() {
      baz(), bar();
    }

    if (bar(), !x) {
-    const { a } = b;
-  }
+      const { a } = b;
+    }
  }

@boopathi boopathi merged commit 4ef735e into master Feb 27, 2017
@boopathi boopathi deleted the if-return-1 branch February 27, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If..return removes something it shouldn't
1 participant