New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #576 #587
Fix #576 #587
Conversation
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 82.8% 82.83% +0.03%
==========================================
Files 44 44
Lines 2896 2896
Branches 1011 1011
==========================================
+ Hits 2398 2399 +1
+ Misses 304 303 -1
Partials 194 194
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 82.8% 82.98% +0.18%
==========================================
Files 44 44
Lines 2896 2898 +2
Branches 1011 1013 +2
==========================================
+ Hits 2398 2405 +7
+ Misses 304 302 -2
+ Partials 194 191 -3
Continue to review full report at Codecov.
|
Thanks. Can you also add a test for this ? |
@boopathi Test added. |
any chance to merge this in master soon? production build broken for many! 😱 |
We will release a new version today with this fix. |
People were calling
"foo".toString()
or["foo", "bar"].toString()
, which returned the real JS string"[object Object]"
, the stringified version of the replacements object. Fixes #576.I just noticed this: