Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babili stripping out license comment. #347

Closed
FezVrasta opened this issue Dec 16, 2016 · 4 comments
Closed

Babili stripping out license comment. #347

FezVrasta opened this issue Dec 16, 2016 · 4 comments

Comments

@FezVrasta
Copy link

FezVrasta commented Dec 16, 2016

This time I tried it directly with CLI.

/**!
 * @fileOverview Kickass library to create and place poppers near their reference elements.
 * @version 1.0.0-alpha.7
 * @license
 * Copyright (c) 2016 Federico Zivolo and contributors
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */    
(function (global, factory) {
  typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
  typeof define === 'function' && define.amd ? define(factory) :
[...]

this comment gets stripped out with this config:

"env": {
    "production": {
        "presets": ["babili"]
    }
}

even adding comments: true.

Subsequent comments are preserved.

@FezVrasta
Copy link
Author

FezVrasta commented Dec 16, 2016

More generically, seems like any comment before the UMD closure gets stripped out, everything inside acts normally and follows the rules.

By the way, even if I position the license inside the closure, it gets stripped out when I set comments: false, I would expect the @license comments to be preserved.

@vigneshshanmugam
Copy link
Member

#325..

It should fine after the release i guess.

@hokkey
Copy link

hokkey commented Feb 11, 2017

+1

@vigneshshanmugam
Copy link
Member

Its already fixed and available in the current releases. Feel free to reopen if you see any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants