babili is removing function arguments in scope of eval call

[targos]

The following code:

'use strict';
function myEval(code, _var_) {
  eval(code);
}
myEval('console.log(_var_)', 'myValue');

Is transformed to:

'use strict';function myEval(code){eval(code)}myEval('console.log(_var_)','myValue');

Which does not work.

I'm using babel-preset-babili v0.0.9. The bug was not present in v0.0.5. I suppose it was introduced in 10b114f.

[kangax]

I'm surprised this didn't break our eval tests.

[kangax]

Oh, we only test for mangling, not argument removal — https://github.com/babel/babili/blob/b8bac37d02c471e2c0f7a845b8afce572870092c/packages/babel-plugin-minify-mangle-names/__tests__/mangle-names-test.js#L493 🙈

[targos]

I still get the same output with babili 0.0.11 which includes #371. Do I need to set an option?

[targos]

Unless I'm mistaken, can this be reopen, please?

[boopathi]

Oh. Yeah. I'll check this.

[targos]

Hello. Can you please open again? The issue is back in latest babili version (example).

[boopathi]

Interesting. I tried it with the master branch which was released a few days ago and this bug is not present. The repl is outdated I suppose - I'll check that.

[j-f1]

It looks like the REPL is running Babili 0.0.9 (run Babili.version in the DevTools), and the latest is 0.1.4

[targos]

I checked with the latest release on my app. Maybe this testcase is too simple now. I will check again.

[targos]

@boopathi here is the result I get with babel-preset-babili@0.1.4:

$ cat test.js
'use strict';
function myEval(code, _var_) {
  eval(code);
}
myEval('console.log(_var_)', 'myValue');

$ babel test.js --presets babili
'use strict';function myEval(a,b){eval(a)}myEval('console.log(_var_)','myValue');