fix: handle non array statements in evaluate helper #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vigneshshanmugam
commented
May 14, 2018
•
vigneshshanmugam
commented
- fix 0.4.2 breaks - passes invalid data to babel-helper-evaluate-path #845
- fix Something went wrong when updating #844
vigneshshanmugam
changed the title
boopathi
reviewed
May 14, 2018
| declaration.parentPath.isSwitchCase() | ||
| t.isIfStatement(declaration.parentPath) || | ||
| t.isLoop(declaration.parentPath) || | ||
| t.isSwitchCase(declaration.parentPath) |
There was a problem hiding this comment.
this should be declaration.parentPath.node.
There was a problem hiding this comment.
The problem with that is it would fail if node is removed, so I went with this check which we do already when binding is of kind "var"
There was a problem hiding this comment.
yeah. so isRemoved should be the first check. I think there is a difference between using t.is methods on a path and a node.
There was a problem hiding this comment.
I went back to using path.isCheck since its wrong to use types check for path as you mentioned.
boopathi
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.