Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split mangleScope logic to smaller functions #853

Merged
merged 1 commit into from May 16, 2018
Merged

refactor: split mangleScope logic to smaller functions #853

merged 1 commit into from May 16, 2018

Conversation

boopathi
Copy link
Member

This is to better measure the performance of individual items. mangleScope is one of the slowest APIs in babel-minify.

@boopathi boopathi added the Tag: Internal Pull Request changing project internals - code that is NOT published label May 16, 2018
vigneshshanmugam
vigneshshanmugam approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, Did we already know which one takes more time out of these two?

@boopathi
Copy link
Member Author

@vigneshshanmugam Neither (or not sure). Both of them take 0.1ms 🤷‍♂️.

@boopathi boopathi merged commit 7195fa9 into master May 16, 2018
@boopathi boopathi deleted the refactor-mangle-scope branch May 16, 2018 18:35
This was referenced Sep 25, 2018
Closed
Closed
Closed
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees
No one assigned
Labels
Tag: Internal Pull Request changing project internals - code that is NOT published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boopathi @vigneshshanmugam