Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(builtins): remove path.get calls #857

Merged
merged 1 commit into from May 17, 2018
Merged

perf(builtins): remove path.get calls #857

merged 1 commit into from May 17, 2018

Conversation

vigneshshanmugam
Copy link
Member

  • this is a micro optimisation for built-ins transform
  • Yields around ~30-40 ms on three.js

@vigneshshanmugam vigneshshanmugam added the Tag: Perf Pull Request improving Performance label May 17, 2018
@boopathi boopathi merged commit 830ce3f into master May 17, 2018
@boopathi boopathi deleted the micro-opt-1 branch May 17, 2018 15:57
This was referenced Sep 25, 2018
Closed
Closed
Closed
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boopathi boopathi boopathi approved these changes

Assignees
No one assigned
Labels
Tag: Perf Pull Request improving Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vigneshshanmugam @boopathi