Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submitter refactoring points #178

Open
gitferry opened this issue Jun 22, 2023 · 0 comments
Open

Submitter refactoring points #178

gitferry opened this issue Jun 22, 2023 · 0 comments
Assignees
@gitferry
Labels
enhancement New feature or request

Comments

@gitferry
Copy link
Collaborator

Some improvement ideas brought up by @KonradStaniec:

  1. SendCheckpointToBTC is starting becoming a bit too complex for my taste and handles too much. Imo resendSecondTxOfCheckpointToBTC should be extracted to separate function and handled in main event loop.
  2. Before doing rbf, we could check if previous tx is in mempool still. This way we could make sure we are really sending tx with larger fee
@gitferry gitferry added the enhancement New feature or request label Jun 22, 2023
@gitferry gitferry self-assigned this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitferry gitferry

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gitferry