Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bacalhau WebUI does not work with TLS #3774

Open
frrist opened this issue Apr 10, 2024 · 1 comment
Open

bacalhau WebUI does not work with TLS #3774

frrist opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
comp/ui Concerns the user interface th/security Theme: Focuses on security features and fixes type/bug Type: Something is not working as expected
Milestone

Comments

@frrist
Copy link
Member

frrist commented Apr 10, 2024

The WebUI needs to accept a TLS config at a minimum, currently it does not.

if startWebUI {
listenPort, err := config.Get[int](types.NodeWebUIPort)
if err != nil {
return err
}
apiURL := standardNode.APIServer.GetURI().JoinPath("api", "v1")
go func() {
// Specifically leave the host blank. The app will just use whatever
// host it is served on and replace the port and path.
apiPort := apiURL.Port()
apiPath := apiURL.Path
err := webui.ListenAndServe(ctx, "", apiPort, apiPath, listenPort)
if err != nil {
cmd.PrintErrln(err)
}
}()
}

In order to enable the work done in #3711 this issue needs to be addressed as there is no point sharing a token with the WebUI over an unsecured connection.

@frrist frrist added the type/bug Type: Something is not working as expected label Apr 10, 2024
@frrist
Copy link
Member Author

frrist commented Apr 10, 2024

I believe the simple/correct fix here is to re-use the API server config, or at least a portion of it, to instantiate the WebUI.

@frrist frrist added this to the Release v1.3.1 milestone Apr 11, 2024
@frrist frrist self-assigned this Apr 15, 2024
@wdbaruni wdbaruni added comp/ui Concerns the user interface th/security Theme: Focuses on security features and fixes labels Apr 16, 2024
@frrist frrist modified the milestones: v1.3.1, 1.3.2 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/ui Concerns the user interface th/security Theme: Focuses on security features and fixes type/bug Type: Something is not working as expected
Projects
Status: Inbox
Development

No branches or pull requests

2 participants