New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-by-one error when setting node bad actors #3787

Open

simonwo opened this issue Apr 12, 2024 · 0 comments

Labels

type/bug

Contributor

simonwo commented Apr 12, 2024 •

edited

When using the --bad-compute-actors or --bad-requester-actors flags on devstack, you always get one more node than requested.

The logic here is a classic off-by-one error:

bacalhau/pkg/devstack/devstack.go

Lines 234 to 235 in 67eaa11

    
           isBadComputeActor := (stackConfig.NumberOfBadComputeActors > 0) && (i >= computeNodeCount-stackConfig.NumberOfBadComputeActors) 
        
           isBadRequesterActor := (stackConfig.NumberOfBadRequesterActors > 0) && (i >= requesterNodeCount-stackConfig.NumberOfBadRequesterActors)

The text was updated successfully, but these errors were encountered:

simonwo added the type/bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment