Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic enqueue of evaluations #3972

Closed
Tracked by #3987
wdbaruni opened this issue May 5, 2024 · 0 comments · Fixed by #3998
Closed
Tracked by #3987

Atomic enqueue of evaluations #3972

wdbaruni opened this issue May 5, 2024 · 0 comments · Fixed by #3998
Assignees
Labels
comp/datastore Related to job and execution store comp/eval-broker Issues related to evaluation broker type/enhancement Type: New features or enhancements to existing features

Comments

@wdbaruni
Copy link
Collaborator

wdbaruni commented May 5, 2024

In many places we update the state of jobs or executions, then create an evaluation, and then enqueue the evaluation to the broker. All of these operations are not atomic and not in a single transaction. This can result in a lot of edge cases and potentially dangling or stale jobs and executions due to partial update of their state, but failure to trigger their re-evaluation.

We need to look into ways to do these operations atomically in a single transaction. This is might be easier to update the job state and create an evaluation in a single transaction as they are part of the same datastore, but the evaluation broker has its own in-memory state, and we need to figure out a way to implement state watchers where we don't need to explicitly enqueue evaluations, but allow the broker to consume state events and enqueue an evaluation whenever one is created

@wdbaruni wdbaruni added type/enhancement Type: New features or enhancements to existing features comp/datastore Related to job and execution store comp/eval-broker Issues related to evaluation broker labels May 5, 2024
@wdbaruni wdbaruni self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/datastore Related to job and execution store comp/eval-broker Issues related to evaluation broker type/enhancement Type: New features or enhancements to existing features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant