Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: The issue of AWS Code Commit integration #24763

Open
2 tasks done
Kang3498 opened this issue May 14, 2024 · 1 comment
Open
2 tasks done

🐛 Bug Report: The issue of AWS Code Commit integration #24763

Kang3498 opened this issue May 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Kang3498
Copy link

Kang3498 commented May 14, 2024

📜 Description

First of all, thank you so much for creating the AWS Codecommit Integration feature.

I tried this feature as soon as it was released and I found one problem.

In the link below, config.host is forced to console.aws.amazon.com, so, If I set repoContentsUrl to {region}.console.aws.amazon.com in the catalog:register action, No Integration error occurs.
https://github.com/stijnbrouwers/backstage/blob/master/packages/integration/src/awsCodeCommit/config.ts#L67

Instead, if I remove the region from the url, an error occurs due to the link below.
https://github.com/stijnbrouwers/backstage/blob/master/packages/backend-common/src/reading/AwsCodeCommitUrlReader.ts#L70

I think it should be changed to load the host from config instead of forcefully assigning it in the first link.

👍 Expected behavior

I think the steps below should succeed.

  input:
    catalogInfoPath: .backstage/catalog-info.yaml
    repoContentsUrl: https://ap-northeast-2.console.aws.amazon.com/codesuite/codecommit/repositories/test-repo/browse/--/

👎 Actual Behavior with Screenshots

InputError: No integration found for host https://ap-northeast-2.console.aws.amazon.com/codesuite/codecommit/repositories/test-repo/browse/refs/heads/main/--/catalog-info.yaml

👟 Reproduction steps

  1. make simple template
  2. add Register step like below

📃 Provide the context for the Bug.

No response

🖥️ Your Environment

backstage : v1.26.5

@backstage/backend-common: 0.21.6
@backstage/integration: 1.10.0

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@Kang3498 Kang3498 added the bug Something isn't working label May 14, 2024
@Kang3498 Kang3498 reopened this May 14, 2024
@Kang3498 Kang3498 changed the title 🐛 Bug Report: The URL of AWS Codecommit Integration is not recognized properly. 🐛 Bug Report: The issue of AWS Code Commit integration May 14, 2024
@Kang3498
Copy link
Author

I created a PR that can be modified. (#24771)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant