Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to change text color and/or change text color automatically #67

Open
nnmrts opened this issue Jan 11, 2021 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@nnmrts
Copy link

nnmrts commented Jan 11, 2021

Feel free to split this issue into two seperate ones, once it's needed.

shields.io kinda does this already. Choosing a color of #ffffff for example, results in dark text instead of the default white one:


https://img.shields.io/badge/badge-test-ffffff

badgen does this:


https://badgen.net/badge/badge/test/ffffff

I think shields.io uses a contrast checker internally, probably https://github.com/jxnblk/colorable to determine if it should use bright or dark text. While badgen should do the same, I think an option to customize the text color would be great as well. This is something shields.io doesn't have btw.

Being able to change icon color like you can with shields.io would be nice too, but I guess that's yet another seperate issue.

@nnmrts
Copy link
Author

nnmrts commented Feb 4, 2021

@amio ? Is this repo still maintained?

@amio amio added the enhancement New feature or request label Feb 5, 2021
@amio
Copy link
Member

amio commented Feb 5, 2021

@nnmrts Yep, sorry for the late response, just a little busy recently. PR's welcome 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants