Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependency wait-on to v5 #257

Merged
merged 1 commit into from Jul 9, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 5, 2020

This PR contains the following updates:

Package Type Update Change
wait-on dependencies major 4.0.0 -> 5.0.3

Release Notes

jeffbski/wait-on

v5.0.3

Compare Source

update to lodash@4.17.19

v5.0.2

Compare Source

lodash@4.17.18 update which resolved some potential lodash vulnerabilities

v5.0.1

Compare Source

Force axios to use http adapter to keep logs clean if jest/jsdom are used with the wait-on API.

If jest/jsdom is used then a polyfill for xhr is created which will cause axios to default the adapter to it. Since jsdom logs all errors use of wait-on will have any failed attempts to connect logged which is rather noisy and misleading.

By forcing axios to use the node.js http adapter instead this problem is bypassed keeping logs clean.

v5.0.0

Compare Source

Switch HTTP client from request to axios

Since the request package is no longer receiving updates, wait-on switched to using axios. Attempt to keep the same wait-on options as much as possible.

These breaking changes occurred in the switch:

  1. There is only one option for redirects followRedirect: true|false (defaults to true).
  2. httpSignature is not implemented in axios and now not available. (If this feature is still desired, please help by providing a pull request to implement it.)
  3. auth allows only username and password but not the previous aliases user and pass

add optional validateStatus fn property

If validateStatus property is provided in the
config and set to a function, it will use this to
validate whether a status is valid.

The default validateStatus if not provided is

validateStatus: function (status) {
  return status >= 200 && status < 300;
}

To also allow a 401 unauthorized as a valid status

validateStatus: function (status) {
  return status === 401 || (status >= 200 && status < 300);
}

v4.0.2

Compare Source

Updated dependencies which closed security vulnerability in minimist and acorn.

v4.0.1

Compare Source


Renovate configuration

馃搮 Schedule: At any time (no schedule defined).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/wait-on-5.x branch 2 times, most recently from 81c93d1 to eea3eaa Compare July 8, 2020 17:37
@bmitchinson
Copy link

Bumping this upgrade PR, as a lodash dependency is broken when using newer versions of cypress.

See #269

@renovate renovate bot changed the title fix(deps): update dependency wait-on to v5 Update dependency wait-on to v5 Jul 9, 2020
@bahmutov bahmutov changed the title Update dependency wait-on to v5 fix: update dependency wait-on to v5 Jul 9, 2020
@bahmutov bahmutov merged commit 885a60b into master Jul 9, 2020
@github-actions
Copy link

github-actions bot commented Jul 9, 2020

馃帀 This PR is included in version 1.11.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants