Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sails-postgresql adapter doesn't work with new Node v14 #6981

Open
meltyshev opened this issue Apr 28, 2020 · 6 comments
Open

sails-postgresql adapter doesn't work with new Node v14 #6981

meltyshev opened this issue Apr 28, 2020 · 6 comments
Labels

Comments

@meltyshev
Copy link

Node version: 14.0.0
DB adapter & version: sails-postgresql@1.0.2


Hi! pg@6.1.6 dependency in machinepack-postgresql doesn't work with new Node v14 (brianc/node-postgres#2170).

@sailsbot
Copy link

@meltyshev Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@johnabrams7 johnabrams7 added node version issue postgresql Issue only occurs when using PostgreSQL labels May 1, 2020
@mikermcneil
Copy link
Member

@meltyshev Thanks for the heads up! This is on our list to address in upcoming weeks.

@robertomarega
Copy link

@mikermcneil , I have the same problem. Pls. it is pretty urgent having a fix. I see that the latest update in sails-postgresql is about one year ago. Will the new versions of node be supported?

@johnabrams7
Copy link
Contributor

johnabrams7 commented Jul 22, 2020

@robertomarega Yes, the new versions of node will be supported eventually (and inevitably). If you don't mind sharing, what is your urgent use case for the newer version(s) of node? Many thanks in advance.

In the meantime, we're developing the sails-sql adapter to ultimately take over sails-postgresql support. It will share a combination of support for MySQL, PostgreSQL (under construction), and Microsoft SQL Server (MSSQL)). 👍

@Allain55
Copy link

Is there some kind of workaround? I'd need Node 14 support because I'm updating an old app and I would like to move it to the same server where another app is running which is already using features of Node 14

@rachaelshaw
Copy link
Member

@Allain55 #7022 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

7 participants