Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support devices with FPS > 60 #135

Open
Almouro opened this issue Jul 4, 2023 · 0 comments
Open

Support devices with FPS > 60 #135

Almouro opened this issue Jul 4, 2023 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Almouro
Copy link
Member

Almouro commented Jul 4, 2023

What

Max FPS is set to 60 in the code
We need to account for devices with a higher refresh rate

How to implement

  • this file needs to be changed flashlight-open-source/packages/platforms/android/src/commands/atrace/pollFpsUsage.ts
  • score calculation need to take into account max fps flashlight-open-source/packages/core/reporter/src/reporting/getScore.ts

We need to add screenRefreshRate into the interfaces TestCaseResult and AveragedTestCaseResult
We need to find a way to measure it and add it to the report

So that max FPS in graphs and score is max FPS du device

@Almouro Almouro added bug Something isn't working enhancement New feature or request labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants