{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":514979405,"defaultBranch":"main","name":"craytracer","ownerLogin":"banga","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-07-17T23:34:11.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/541603?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1705105061.0","currentOid":""},"activityList":{"items":[{"before":"6e807b24de03b4fb8f5a92ee0e6b814301755fcb","after":"9acfb0d906466d4419af342c4b1d59617d5c8b64","ref":"refs/heads/main","pushedAt":"2024-04-06T16:22:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Add anthropic scene","shortMessageHtmlLink":"Add anthropic scene"}},{"before":"4820473911886343cc737bf0cc639e55efc89b86","after":"6e807b24de03b4fb8f5a92ee0e6b814301755fcb","ref":"refs/heads/main","pushedAt":"2024-02-06T05:17:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Delete unintentionally checked-in blender file","shortMessageHtmlLink":"Delete unintentionally checked-in blender file"}},{"before":"db6fd64aa2a2902b9e7fbb1eeb48d604d1a5ae3e","after":"4820473911886343cc737bf0cc639e55efc89b86","ref":"refs/heads/main","pushedAt":"2024-02-01T14:24:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Fix test","shortMessageHtmlLink":"Fix test"}},{"before":"03e8133f440566c347574039ec730ab524bd9a83","after":"db6fd64aa2a2902b9e7fbb1eeb48d604d1a5ae3e","ref":"refs/heads/main","pushedAt":"2024-02-01T14:10:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Fix test","shortMessageHtmlLink":"Fix test"}},{"before":"327f38b2fbab31ba6afac0a9897b63662ad13afa","after":"03e8133f440566c347574039ec730ab524bd9a83","ref":"refs/heads/main","pushedAt":"2024-02-01T02:17:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Also tile in sample space when rendering\n\nMakes it easier to iterate on scenes by displaying (noisier) versions of\nthe full image sooner. Did not seem to have any noticeable impact on\nperformance.","shortMessageHtmlLink":"Also tile in sample space when rendering"}},{"before":"037b716c85dc801786072c7477ccc1e48a64719e","after":"327f38b2fbab31ba6afac0a9897b63662ad13afa","ref":"refs/heads/main","pushedAt":"2024-01-31T22:50:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Fix color conversion for textures\n\nThe textures were appearing washed out in all the renders, which turned\nout to be because of the gamma correction we do. So we do the inverse\nwhen converting texture values to Color. This is pretty rudimentary, but\nworks for now.\n\nAlso fixed the staircase scene to use the correct texture for the\nstairs.","shortMessageHtmlLink":"Fix color conversion for textures"}},{"before":"a368be7a26dbc151d91126d480122dac3122677f","after":"037b716c85dc801786072c7477ccc1e48a64719e","ref":"refs/heads/main","pushedAt":"2024-01-31T16:54:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Fix most tests\n\nRemoving `PartialEq` makes tests much harder to write, so re-enabled it\non a couple of small types. But the scene parser test also relies on\ncomparing entire `Scene`s which will likely reintroduce performance\nissues, so that will have to be handled differently.","shortMessageHtmlLink":"Fix most tests"}},{"before":"bbfd07916ad1d2b607bc76dd3a47cd3adbcbd297","after":"a368be7a26dbc151d91126d480122dac3122677f","ref":"refs/heads/main","pushedAt":"2024-01-31T15:12:54.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Update scenes with textures to better povs","shortMessageHtmlLink":"Update scenes with textures to better povs"}},{"before":"493eb0243dd02471f8cca02622dddd1459ee17af","after":"bbfd07916ad1d2b607bc76dd3a47cd3adbcbd297","ref":"refs/heads/main","pushedAt":"2024-01-30T21:56:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Add a render of the staircase scene\n\nTweaked the material to use metal and glass materials where appropriate and switched to an area light so it would be less noisy.","shortMessageHtmlLink":"Add a render of the staircase scene"}},{"before":"faa2f527236f56f6d85e7456b68025454f13b597","after":"493eb0243dd02471f8cca02622dddd1459ee17af","ref":"refs/heads/main","pushedAt":"2024-01-30T17:31:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Log level from env should override the default","shortMessageHtmlLink":"Log level from env should override the default"}},{"before":"b3f8c2facd97525b6697205148075db06bafbcfd","after":"faa2f527236f56f6d85e7456b68025454f13b597","ref":"refs/heads/main","pushedAt":"2024-01-29T21:32:03.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Add cornell scene\n\nThis includes a bunch of variants on the standard cornell box, uploaded at https://github.com/jvm-graphics-labs/awesome-3d-meshes/tree/master/McGuire. I had to add a hack to the obj loader to start supporting reflective surfaces.","shortMessageHtmlLink":"Add cornell scene"}},{"before":"5ac03cd21abbf71141f7a0ffb8700de61c8f0f08","after":"b3f8c2facd97525b6697205148075db06bafbcfd","ref":"refs/heads/main","pushedAt":"2024-01-28T16:23:33.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Sample lights by power\n\nProduces somewhat lower noise in the staircase scene, though the\nfireflies are still there.","shortMessageHtmlLink":"Sample lights by power"}},{"before":"6df7ffe2fe7d94ed66807525adc0e475eedf3469","after":"5ac03cd21abbf71141f7a0ffb8700de61c8f0f08","ref":"refs/heads/main","pushedAt":"2024-01-26T03:24:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Move macros to their own module\n\nAnd use $crate to avoid having to import dependencies","shortMessageHtmlLink":"Move macros to their own module"}},{"before":"6b15599791873ed75151a5d902d72a64ae71d726","after":"6df7ffe2fe7d94ed66807525adc0e475eedf3469","ref":"refs/heads/main","pushedAt":"2024-01-25T19:56:24.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Adjust materials scene to match the original look more","shortMessageHtmlLink":"Adjust materials scene to match the original look more"}},{"before":"b5a57e3e585c87852737e4363a4ec4a6ed8ebffe","after":"6b15599791873ed75151a5d902d72a64ae71d726","ref":"refs/heads/main","pushedAt":"2024-01-25T02:48:10.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Add sobol sampler\n\nI think I eventually got it working correctly (at least the images look less noisy). But using it currently triggers asserts in a couple of places that imply either numerical errors or bugs in sampling algorithms somewhere, so it's not currently being used.\n\nSeparately, since I'm using a trait to do polymorphism, it's hard to make the sampler configurable via scene files. I'll probably have to switch over to an enum, or rip out all but one implementations.","shortMessageHtmlLink":"Add sobol sampler"}},{"before":"d1b680eca8a5a012239ec63b3a53d98b9cb27eb1","after":"b5a57e3e585c87852737e4363a4ec4a6ed8ebffe","ref":"refs/heads/main","pushedAt":"2024-01-24T00:35:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"520362e842dcc06df9aea5acdfbb0644de1cb716","after":"d1b680eca8a5a012239ec63b3a53d98b9cb27eb1","ref":"refs/heads/main","pushedAt":"2024-01-23T23:01:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Make Sampler a trait and implement IndependentSampler\n\nNow we can implement other samplers and also make rendering\ndeterministic, which will help with debugging.","shortMessageHtmlLink":"Make Sampler a trait and implement IndependentSampler"}},{"before":"5d7a21e53f471b5996d77b2e6b8d2b40b85a6e4b","after":"520362e842dcc06df9aea5acdfbb0644de1cb716","ref":"refs/heads/main","pushedAt":"2024-01-23T19:30:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Create rust.yml","shortMessageHtmlLink":"Create rust.yml"}},{"before":"be1d431d1a395680a9ea29ecb00c0609a0cab4d1","after":"5d7a21e53f471b5996d77b2e6b8d2b40b85a6e4b","ref":"refs/heads/main","pushedAt":"2024-01-23T03:39:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Use `env_logger` and `log` for logging\n\nMainly to make it easy to filter out the noise from obj loading","shortMessageHtmlLink":"Use <code>env_logger</code> and <code>log</code> for logging"}},{"before":"15f66e09b48b2e1b57a02dde8aa5f82213ee3b98","after":"be1d431d1a395680a9ea29ecb00c0609a0cab4d1","ref":"refs/heads/main","pushedAt":"2024-01-23T01:47:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Reduce memory usage\n\nMake the `Shape` union smaller by moving transformations behind\npointers. Cuts memory usage for large scenes in half and does not appear\nto affect performance. Triangles now have the biggest footprint, which\ncould be reduced by storing indexes into a mesh instead.","shortMessageHtmlLink":"Reduce memory usage"}},{"before":"6d240c7748290f3866480c84199a903b495d34a9","after":"15f66e09b48b2e1b57a02dde8aa5f82213ee3b98","ref":"refs/heads/main","pushedAt":"2024-01-22T22:33:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Add support for triangle area lights\n\nThis finally correctly renders emissive objects within obj files by\ntreating them as area lights.\n\nAfter adding this, I noticed a couple of rendering issues:\n- The area lights themselves were rendering like diffuse surfaces. This\n  was because we were not accounting including the emittance from the\n  area light along the camera ray and also along rays resulting from\n  specular bounces. So now we account for that special case (just like\n  pbrt does).\n- Since we uniformaly sample shapes for area lights, it's possible to\n  sample a point that is not actually going to be hit by the light ray\n  from the intersection. In those cases, we were returning a Delta pdf\n  and treating the light as a Delta light, which would cause fireflies.\n  This is handled by returning a 0.0 NonDelta pdf instead and accounting\n  for that in sample_light.","shortMessageHtmlLink":"Add support for triangle area lights"}},{"before":"81e20406f183df084b007d2e660b9a3f2b3f79cd","after":"6d240c7748290f3866480c84199a903b495d34a9","ref":"refs/heads/main","pushedAt":"2024-01-22T00:21:12.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Improve obj file loading\n\nRead specular, shininess and dissolve values to allow creating shiny and\ntransparent materials. It's still quite limited; might be worth\nswitching to a different source file format.","shortMessageHtmlLink":"Improve obj file loading"}},{"before":"94219560ae47792f958fe3bd8698ce182bbb5171","after":"81e20406f183df084b007d2e660b9a3f2b3f79cd","ref":"refs/heads/main","pushedAt":"2024-01-21T07:03:15.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Update some scenes after the previous fixes\n\nThe room scene is particularly improved by fixing the light leaks & inverted normals.","shortMessageHtmlLink":"Update some scenes after the previous fixes"}},{"before":"ea9b52295c0a1ab2370760fd3d27dbaaa51a99a6","after":"94219560ae47792f958fe3bd8698ce182bbb5171","ref":"refs/heads/main","pushedAt":"2024-01-20T15:59:08.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Allow triggering a render at a specific pixel\n\nRearranged preview mode to allow clicking on a pixel in the window and\ntriggering a single render for that pixel. This makes it possible to\nattach to the renderer and (ahem) trace its execution, which should make\nit much easier to debug issues.","shortMessageHtmlLink":"Allow triggering a render at a specific pixel"}},{"before":"3f1a46b1112b8475ba6fcb0dd18fad612a7c6075","after":"ea9b52295c0a1ab2370760fd3d27dbaaa51a99a6","ref":"refs/heads/main","pushedAt":"2024-01-19T17:10:26.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Log BVH construction time","shortMessageHtmlLink":"Log BVH construction time"}},{"before":"f1c2bbe04ab0d986f58717b052cb155b606951fd","after":"3f1a46b1112b8475ba6fcb0dd18fad612a7c6075","ref":"refs/heads/main","pushedAt":"2024-01-19T05:37:13.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"BVH construction with surface area heuristic\n\nFinally implemented the method described in pbrt v3. I ran into some interesting edge cases:\n- Degenerate triangles in the room scene caused the total surface area to be 0, which caused NaN costs and impossible to split nodes. Handled it by both skipping them and adding an assert.\n- Some buckets can be entirely empty. I initially had Bounds default to (inf) -> (-inf) but then for those buckets, the surface area would silently be NaN. So I explicitly handle empty buckets now by using Option. This is not apparently handled in pbrt, but I guess works because their cost ends up being infinite?\n\nThis dramatically improves performance on scenes with meshes:\n- `dragon.cry`: `14.85s` -> `10.53s`\n- `room.cry`: `7.45s` -> `4.02s`\n- `washington.cry`: `41.72s` -> `37.39s`","shortMessageHtmlLink":"BVH construction with surface area heuristic"}},{"before":"395987e19cfe3a049506ba10b6fd48588b8f98f0","after":"f1c2bbe04ab0d986f58717b052cb155b606951fd","ref":"refs/heads/main","pushedAt":"2024-01-18T18:52:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Fix render progress indicator\n\nRe-read the tile_index which likely will have increased while the\ncurrent thread was busy rendering. Also render the remaining time.","shortMessageHtmlLink":"Fix render progress indicator"}},{"before":"8315109fbc18f59220fccc628d7c6ee752abb37f","after":"395987e19cfe3a049506ba10b6fd48588b8f98f0","ref":"refs/heads/main","pushedAt":"2024-01-18T18:07:38.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Optimize bvh construction\n\n- Use centroid instead of the extents of the bounding boxes. This\n  appears to dramatically improve intersection time on the room scene\n- In `find_split`, use `select_nth` (i.e. \"quick select\") instead of\n  sorting, which makes it O(n)\n- Use slices to avoid making temporary Vectors","shortMessageHtmlLink":"Optimize bvh construction"}},{"before":"ed4d925e92804fc5ee15c1d76dc765dbdcd0cb4a","after":"8315109fbc18f59220fccc628d7c6ee752abb37f","ref":"refs/heads/main","pushedAt":"2024-01-18T01:43:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Move O, X, Y and Z outside of structs\n\nThat way they can be used concisely without the type prefix","shortMessageHtmlLink":"Move O, X, Y and Z outside of structs"}},{"before":"fcc6a67ea1cb931ea9f42a9e1c29ef03808cc28f","after":"ed4d925e92804fc5ee15c1d76dc765dbdcd0cb4a","ref":"refs/heads/main","pushedAt":"2024-01-18T00:46:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"banga","name":"Shrey Banga","path":"/banga","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/541603?s=80&v=4"},"commit":{"message":"Update materials image with area light","shortMessageHtmlLink":"Update materials image with area light"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEKbEBAQA","startCursor":null,"endCursor":null}},"title":"Activity · banga/craytracer"}