Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: 目录 #230

Open
7 of 10 tasks
RanKKI opened this issue Oct 4, 2022 · 6 comments
Open
7 of 10 tasks

[Feature Request]: 目录 #230

RanKKI opened this issue Oct 4, 2022 · 6 comments
Labels
enhancement New feature request tier 2

Comments

@RanKKI
Copy link
Member

RanKKI commented Oct 4, 2022

目录的增删查改,包括 我建立的目录某用户的收藏目录

目前已经存在
/v0/indices/{index_id}
/v0/indices/{index_id}/subjects

已实现 #234

  • 新建目录 POST /indices
  • 修改 PUT /indices/{index_id}
  • 增加内容 POST /indices/{index_id}/subjects
  • 修改内容 PUT /indices/{index_id}/subjects/<subject_id>
  • 删除内容 DELETE /indices/{index_id}/subjects/<subject_id>

待实现

  • 收藏目录 POST /indices/{index_id}/collect
  • 取消收藏 DELETE /indices/{index_id}/collect
  • 用户的目录 GET /users/{username}/indices
  • 用户的收藏目录 GET /users/{username}/indices/collect

暂定不添加

  • 删除 DELETE /indices/{index_id}
@RanKKI RanKKI added the enhancement New feature request label Oct 4, 2022
@trim21
Copy link
Contributor

trim21 commented Oct 4, 2022

增加、删除和修改条目看起来OK,用户的目录 GET看起来也ok,其他的不太确定...

@trim21
Copy link
Contributor

trim21 commented Oct 4, 2022 via email

@RanKKI
Copy link
Member Author

RanKKI commented Oct 4, 2022

Private API 和公开 API 的界限是在哪?比如对目录的增删,应该属于公开 API 么?

@trim21
Copy link
Contributor

trim21 commented Oct 4, 2022

Private API是针对前端需要写的,不太需要保证兼容性,公开API是给所有人用得。这个应该是公开的。

@trim21
Copy link
Contributor

trim21 commented Oct 4, 2022

有数据库权限了

@RanKKI RanKKI mentioned this issue Oct 5, 2022
@trim21 trim21 added the tier 2 label Nov 3, 2022
@kagaya85
Copy link
Contributor

kagaya85 commented Mar 9, 2023

Hi there,我可以帮忙尝试实现一下收藏部分的api,这几天抽空理解了下代码和文档,感觉可以开始上手了,有什么其他建议可以帮助我展开工作吗😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request tier 2
Projects
None yet
Development

No branches or pull requests

3 participants