[vault-configurer] Pod should become unhealthy after failing many retries to apply config

[Gentoli]

Is your feature request related to a problem? Please describe.

vault-configurer pod created by the Vault CR fails to apply vault config. There is no clear indication on it failed either in the pod health check or Vault CR status. Had to check logs to see the failure.

Vault CR status:

status:
  conditions:
    - status: 'True'
      type: Healthy
  leader: vault-0
  nodes:
    - vault-0

Describe the solution you'd like

• vault-configurer pod should becomes unhealthy indicating an issue after number of retires
• operator should update the CR to show vault-configurer failed

Describe alternatives you've considered
None

Additional context

I am running in GKE with usually only a single node but with the vault CR configured to schedule two pods on different nodes in case of upgrade or replacing node (one pod is usually stuck on unschedulable).
Edit: Scaled the size to 1 and the Vault CR shows healthy even when vault-configurer stuck retrying.

[github-actions]

Thank you for your contribution! This issue has been automatically marked as stale because it has no recent activity in the last 60 days. It will be closed in 20 days, if no further activity occurs. If this issue is still relevant, please leave a comment to let us know, and the stale label will be automatically removed.

[ramizpolic]

Hiya @Gentoli, thanks for reporting this! We could add an option (flag/env) to control the number of allowed retries before exiting with an error which should resolve this issue.

However, as this requires extensions to other components as well (including the CRs), we'd have to plan it ahead. If there's still interest for this feature, we could add it to our backlog. Cheers!