Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to values.yaml controlling installation of CRDs #256

Open
2 tasks done
gecube opened this issue Nov 3, 2023 · 2 comments
Open
2 tasks done

Add flag to values.yaml controlling installation of CRDs #256

gecube opened this issue Nov 3, 2023 · 2 comments
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Milestone

Comments

@gecube
Copy link

gecube commented Nov 3, 2023

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

Good day colleagues!

I want to leverage the whole GitOps approach and deploy all components of cluster in one go. It also applies to vault operator. The issue is that it is difficult now to make a proper order between different manifests. Let say I want to install

apiVersion: "vault.banzaicloud.com/v1alpha1"
kind: "Vault"
metadata:
  name: "vault"

but I can't do it before I will install the operator itself. It applies to different gitops solutions like ArgoCD and FluxCD. I can overrun it and solve by creation a complex configuration, but I don't like it.

Proposed Solution

Introduce the new flag in the values of helm chart like it's implemented in cert-manager:

cert-manager/cert-manager#2330
https://github.com/cert-manager/cert-manager/blob/5141dddf2c0c5e10c5d4452c99a2e260c6eb2983/deploy/charts/cert-manager/values.yaml#L53

The default value will be installCRDs: true. And the behaviour of the chart won't change.
But I will choose installCRDs: false and install CRDs in different kustomization level in proper order.

Alternatives Considered

Split CRDs and the base part of vault operator into different charts (with the synchronous versioning) like it was done in emissary or Linkerd.

Additional Information

No response

@gecube gecube added the kind/enhancement Categorizes issue or PR as related to an improvement. label Nov 3, 2023
@akijakya
Copy link
Contributor

akijakya commented Nov 3, 2023

Hi @gecube, thanks for the feedback, this is definitely something we should be looking at soon!

@ramizpolic ramizpolic modified the milestones: v1.23.0, v1.22.0 Nov 16, 2023
Copy link

Thank you for your contribution! This issue has been automatically marked as stale because it has no recent activity in the last 60 days. It will be closed in 20 days, if no further activity occurs. If this issue is still relevant, please leave a comment to let us know, and the stale label will be automatically removed.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jan 21, 2024
@ramizpolic ramizpolic added lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jan 23, 2024
@ramizpolic ramizpolic pinned this issue Feb 9, 2024
@ramizpolic ramizpolic unpinned this issue Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Projects
Status: 🔖 Ready for work
Development

No branches or pull requests

3 participants