Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceAnnotations or similar field for Vault CRD since LoadBalancerIP is deprecated #354

Open
jpuskar opened this issue Jul 24, 2022 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jpuskar
Copy link

jpuskar commented Jul 24, 2022

Right now the Vault operator can use a specific IP address from metallb via the spec.LoadBalancerIP field.
This is required for those of us running on-prem clusters who have many different metallb address pools, etc.

However, this field is deprecated in k8s 1.24.

kubernetes/kubernetes#107235

Perhaps something like spec.ServiceAnnotations should be available instead so that the following pattern could be used to achieve the same purpose:

kind: Service
metadata:
    annotations:
        metallb.universe.tf/address-pool: my-vault-address-pool-name

Apologies ahead of time if I'm just confused about how this works or if missed an already-existing feature. I read through the source but Go is (not yet) my strong suit.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jan 28, 2024
@ramizpolic ramizpolic added kind/feature Categorizes issue or PR as related to a new feature. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jan 30, 2024
@ramizpolic ramizpolic transferred this issue from bank-vaults/bank-vaults Jan 30, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Mar 31, 2024
@csatib02 csatib02 removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Mar 31, 2024
Copy link

github-actions bot commented Jun 2, 2024

Thank you for your contribution! This issue has been automatically marked as stale because it has no recent activity in the last 60 days. It will be closed in 20 days, if no further activity occurs. If this issue is still relevant, please leave a comment to let us know, and the stale label will be automatically removed.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jun 2, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 2, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 2, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants