Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flag to merge instead of patch thanos.spec.storeGateway.containerOverrides.volumeMounts #109

Open
NissesSenap opened this issue Mar 22, 2021 · 0 comments

Comments

@NissesSenap
Copy link

Is your feature request related to a problem? Please describe.

When setting a custom data store in thanos.spec.storeGateway.containerOverrides.volumeMounts the objectstore configmap get's overwritten.
This kind of destroys the usability of having ObjectStore.

Describe the solution you'd like to see

Add bool merge under thanos.spec.storeGateway.containerOverrides.volumeMounts or set merge/patch as default.

Example

apiVersion: monitoring.banzaicloud.io/v1alpha1
kind: Thanos
metadata:
  name: thanos-sample
spec:
  queryDiscovery: true
  query: {}
  storeGateway:
    containerOverrides:
      volumeMounts:
        - name: thanos-data
          mountPath: ./data
          merge: true
        - mountPath: /etc/config/
          name: objectstore-secret
          readOnly: true
    workloadOverrides:
      volumes:
        - name: thanos-data
          emptyDir: {}
        - name: objectstore-secret
          secret:
            defaultMode: 420
            secretName: thanos-objstore-config

Describe alternatives you've considered

Ether make merge/path to the default or make it opt in or opt out.

Additional context

I need to define a location to store my volumeMounts due to that I have PSP rules that say I'm not allowed to write data to root dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant