Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store option "timeRanges" has no effect #73

Open
craigfurman opened this issue Nov 17, 2020 · 0 comments
Open

Store option "timeRanges" has no effect #73

craigfurman opened this issue Nov 17, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@craigfurman
Copy link

Describe the bug

Setting Thanos.spec.storeGateway.timeRanges, as documented in https://github.com/banzaicloud/thanos-operator/blob/master/docs/types/thanos_types.md, has no effect.

Steps to reproduce the issue:

Upload the following manifests:

apiVersion: monitoring.banzaicloud.io/v1alpha1
kind: Thanos
metadata:
  name: thanos
spec:
  storeGateway:
    timeRanges:
    - maxTime: -24h
---
apiVersion: monitoring.banzaicloud.io/v1alpha1
kind: StoreEndpoint
metadata:
  name: bucket
spec:
  config:
    mountFrom:
      secretKeyRef:
        key: EXAMPLE
        name: EXAMPLE
  thanos: thanos

Observe that the resultant store pods do not have a --max-time flag

Expected behavior

I'd expect the resultant store pods' Pod.spec.containers.args to have a --max-time=-24h argument.

Screenshots

Additional context

It's possible I've misunderstood the operator code, but it looks like this option does nothing, looking at this setArgs function. We either need to set the flags with reflection on a thanos struct tag, if this is not too awkward to do with the nested struct, or write code to handle this field.

@craigfurman craigfurman changed the title store option "timeRanges" has no effect Store option "timeRanges" has no effect Nov 17, 2020
@tarokkk tarokkk self-assigned this Mar 3, 2021
@tarokkk tarokkk added the enhancement New feature or request label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants