Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore usability of codegen.ts #766

Open
tetraptych opened this issue May 8, 2018 · 0 comments
Open

Restore usability of codegen.ts #766

tetraptych opened this issue May 8, 2018 · 0 comments

Comments

@tetraptych
Copy link
Contributor

PR #763 fixed issue #762 by removing certain "states" from the defined states type. This created compile-time errors in zipCodesByCountyByState.ts: the output of codegen.ts no longer had the expected type, since some records in the API response no longer could be assigned the correct type.

We should allow for this file to be created from codegen directly without the need for a manual step ensuring that the problematic lines do not appear in zipCodesByCountyByState.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant