Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute strip_include_prefix #142

Open
hofbi opened this issue Aug 3, 2023 · 2 comments
Open

Add attribute strip_include_prefix #142

hofbi opened this issue Aug 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@hofbi
Copy link
Contributor

hofbi commented Aug 3, 2023

Thank you for providing these nice rules for cuda. It would be great if the cuda_library and cuda_object would provide and implement the strip_include_prefix attribute and the rules_cc do: https://bazel.build/reference/be/c-cpp#cc_library.strip_include_prefix

@cloudhan cloudhan added the enhancement New feature or request label Aug 3, 2023
@hofbi
Copy link
Contributor Author

hofbi commented Aug 24, 2023

We were looking into the repo to see how we could implement the strip_include_prefix. Checking how rules_cc does it gave us https://bazel.build/versions/6.2.0/rules/lib/cc_common#compile, which has the strip_include_prefix as attribute. For this repo, it looks like you guys implemented your own compile function in https://github.com/bazel-contrib/rules_cuda/blob/main/cuda/private/actions/compile.bzl, hence I think it would make sense to add this attribute there.

Could you give some advise if we are on the right track here or wheter you would implement this differently?

@cloudhan
Copy link
Collaborator

Yeah, if we are going to implement it, we should align it with cc_* rules.

For now, you can wrap you cuh headers with a cc_library first to achieve the purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants