Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: rules_jvm_external should be marked as requiring Bazel 7 #1756

Open
mering opened this issue Apr 4, 2024 · 3 comments
Open

[Bug]: rules_jvm_external should be marked as requiring Bazel 7 #1756

mering opened this issue Apr 4, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mering
Copy link
Contributor

mering commented Apr 4, 2024

What happened?

As rules_jvm_external version 6.0 uses use_repo_rule which has only been introduced in Bazel 7, it should explicitly require Bazel 7 in order to show a clear and actionable error message to the user.

This can be done by adding bazel_compatibility = [">=7.0.0"], to the module() declaration in the MODULE.bazel file.

Version

Development (host) and target OS/architectures: all

Output of bazel --version: 6.x

Version of relevant rules from the WORKSPACE or MODULE.bazel file: see description

Language(s) and/or frameworks involved: irrelevant

How to reproduce

`bazel_dep(name = "rules_jvm_external", version = "6.0")` with Bazel 6.x.

Any other information?

No response

@mering mering added the bug Something isn't working label Apr 4, 2024
@fmeum
Copy link
Contributor

fmeum commented Apr 4, 2024

@shs96c

@shs96c
Copy link
Contributor

shs96c commented Apr 4, 2024

@shs96c
Copy link
Contributor

shs96c commented Apr 22, 2024

This has now been committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants