Read .netrc in go_repository #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been attempted once before in the same fashion with #848, could you check out Jay's comments there? |
blico
reviewed
Aug 6, 2021
blico
approved these changes
Aug 10, 2021
dmivankov
added a commit
to dmivankov/bazel-gazelle
that referenced
this pull request
May 18, 2022
Initial PR to handle netrc had support for auth_patterns bazelbuild#848 But final version didn't bazelbuild#1090 auth_patterns can still be needed, for example for private github repositories Can be used like this ```python go_repository( name = "something", auth_patterns = { "api.github.com": "Bearer <password>", }, importpath = "github.com/someorg/something", strip_prefix = "something-...", type = "zip", urls = ["https://api.github.com/repos/someorg/something/zipball/..."], ) ``` Copying parameter documentation from bazel code
linzhp
pushed a commit
that referenced
this pull request
Jun 12, 2022
Initial PR to handle netrc had support for auth_patterns #848 But final version didn't #1090 auth_patterns can still be needed, for example for private github repositories Can be used like this ```python go_repository( name = "something", auth_patterns = { "api.github.com": "Bearer <password>", }, importpath = "github.com/someorg/something", strip_prefix = "something-...", type = "zip", urls = ["https://api.github.com/repos/someorg/something/zipball/..."], ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What package or component does this PR mostly affect?
go_repository
What does this PR do? Why is it needed?
The URLs that
go_repositorydownloads libraries from may need authentication. We need to support the authentication tokens saved in.netrcsimilar to whathttp_archivedoes.** Which issues(s) does this PR fix?
Fixes #847
** Other notes for review
This is a re-implementation of #848 by addressing @jayconrod's comments there. Besides fixes in the code, these are the responses to Jay's comments:
Bazel 1.2.0 provides these functions (read_netrc, use_netrc): https://github.com/bazelbuild/bazel/blob/1.2.0/tools/build_defs/repo/utils.bzl. However, the third argument to use_netrc was added in Bazel 3.1. So this pull request will require Bazel 3.1, which shouldn't be a big issue as rules_go already requires Bazel 4.0
In module mode, go_repository calls Go toolchain, which already has logic to support netrc without requiring
NETRCenvironment variable.Let's not add these attributes to keep it simple and use the netrc file from default location with default auth pattern for now until some people run into a scenario where customization is needed.