Automatically run bazel mod tidy in @rules_go//go
#3927
+87
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bazel mod tidy` is run if supported and if relevant files change due to the command.
|
Just checking, will this also work for users of go.work workspaces? |
This requires adding the relevant files to https://github.com/bazelbuild/bazel-gazelle/blob/7c84c339075a992ea1a6f720899d91c0e047efe2/internal/bzlmod/go_deps.bzl#L657. Maybe that already happens with the fake |
sluongng
reviewed
May 21, 2024
| if len(diff) > 0 { | ||
| if HasBazelModTidy == "True" { | ||
| _, _ = fmt.Fprintf(os.Stderr, "\nrules_go: Running 'bazel mod tidy' since %s changed...\n", strings.Join(diff, ", ")) | ||
| err = runProcess([]string{"bazel", "mod", "tidy"}, os.Environ(), cwd) |
There was a problem hiding this comment.
FYI: not everybody use the bazel binary from $PATH.
Some folks prefer using bazelisk, b, bb, blaze.
Could we make this configurable somehow? Or better, could we expose a starlark API for this?
linzhp
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
bazel mod tidyis run if supported and if relevant files change due to the command.Which issues(s) does this PR fix?
Fixes #3900
Fixes bazelbuild/bazel-gazelle#1749
Other notes for review