feat(bzlmod): add module_override tag to allow patching in go_deps
#1500
+78
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-french
force-pushed
the
patch
branch
7 times, most recently
from
1800569 to
6545901
Compare
tyler-french
changed the title
module_override tag to allow patching in go_deps
tyler-french
changed the title
module_override tag to allow patching in go_depsmodule_override tag to allow patching in go_deps
fmeum
approved these changes
Apr 7, 2023
fmeum
approved these changes
Apr 7, 2023
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
May 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.30.0` -> `v0.31.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.30.0...v0.31.0) #### What's Changed - feat: allow passing GIT_CONFIG_COUNT and it's related configs by [@​manuelnaranjo](https://togithub.com/manuelnaranjo) in [https://github.com/bazelbuild/bazel-gazelle/pull/1462](https://togithub.com/bazelbuild/bazel-gazelle/pull/1462) - feat(bzlmod): add `module_override` tag to allow patching in go_deps by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1500](https://togithub.com/bazelbuild/bazel-gazelle/pull/1500) - fix typo `build_proto_file_mode` in message by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1504](https://togithub.com/bazelbuild/bazel-gazelle/pull/1504) - fix: support running within a dir named workspace by [@​jbedard](https://togithub.com/jbedard) in [https://github.com/bazelbuild/bazel-gazelle/pull/1498](https://togithub.com/bazelbuild/bazel-gazelle/pull/1498) - fix: check for gazelle command before adding -repo_config flag by [@​cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1501](https://togithub.com/bazelbuild/bazel-gazelle/pull/1501) - language/go: Infer prefix from go.mod by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1497](https://togithub.com/bazelbuild/bazel-gazelle/pull/1497) - don't overwrite directives by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1503](https://togithub.com/bazelbuild/bazel-gazelle/pull/1503) - Support Bzlmod for gazelle itself by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1509](https://togithub.com/bazelbuild/bazel-gazelle/pull/1509) - language/go: Add windows arm64 as a known platform. by [@​connyay](https://togithub.com/connyay) in [https://github.com/bazelbuild/bazel-gazelle/pull/1507](https://togithub.com/bazelbuild/bazel-gazelle/pull/1507) - Adding lifecycle manager by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1475](https://togithub.com/bazelbuild/bazel-gazelle/pull/1475) - Disable protobuf generation for more modules by [@​seh](https://togithub.com/seh) in [https://github.com/bazelbuild/bazel-gazelle/pull/1514](https://togithub.com/bazelbuild/bazel-gazelle/pull/1514) - Support '~' in label repo by [@​mark-thm](https://togithub.com/mark-thm) in [https://github.com/bazelbuild/bazel-gazelle/pull/1518](https://togithub.com/bazelbuild/bazel-gazelle/pull/1518) - language/go: Handle `unix` build tag. by [@​connyay](https://togithub.com/connyay) in [https://github.com/bazelbuild/bazel-gazelle/pull/1512](https://togithub.com/bazelbuild/bazel-gazelle/pull/1512) - Pass data arg through to sh_binary if defined by [@​Preston4tw](https://togithub.com/Preston4tw) in [https://github.com/bazelbuild/bazel-gazelle/pull/1483](https://togithub.com/bazelbuild/bazel-gazelle/pull/1483) - remove circular override hack by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1515](https://togithub.com/bazelbuild/bazel-gazelle/pull/1515) - Add major version suffix download example by [@​kriswuollett](https://togithub.com/kriswuollett) in [https://github.com/bazelbuild/bazel-gazelle/pull/1453](https://togithub.com/bazelbuild/bazel-gazelle/pull/1453) - Relax parsing of labels by [@​purkhusid](https://togithub.com/purkhusid) in [https://github.com/bazelbuild/bazel-gazelle/pull/1508](https://togithub.com/bazelbuild/bazel-gazelle/pull/1508) - bzlmod: Add `build_file_generation` to `gazelle_override` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1522](https://togithub.com/bazelbuild/bazel-gazelle/pull/1522) - Fix incremental build of to bootstrap Gazelle by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1529](https://togithub.com/bazelbuild/bazel-gazelle/pull/1529) - Support macros/rules packed within bazel `struct` by [@​birunts](https://togithub.com/birunts) in [https://github.com/bazelbuild/bazel-gazelle/pull/1524](https://togithub.com/bazelbuild/bazel-gazelle/pull/1524) - Prefer non-proto over proto deps in external repos by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1537](https://togithub.com/bazelbuild/bazel-gazelle/pull/1537) - bzlmod: Return `extension_metadata` to automate `use_repo` fixes by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1511](https://togithub.com/bazelbuild/bazel-gazelle/pull/1511) - Fix `go:embed` failing to add `embedsrcs` for subdirectories named build by [@​sgavinio](https://togithub.com/sgavinio) in [https://github.com/bazelbuild/bazel-gazelle/pull/1539](https://togithub.com/bazelbuild/bazel-gazelle/pull/1539) - Remove support for godep and dep by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1541](https://togithub.com/bazelbuild/bazel-gazelle/pull/1541) - Avoid putting -repo_config after directories by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1544](https://togithub.com/bazelbuild/bazel-gazelle/pull/1544) - Dropping -args by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1546](https://togithub.com/bazelbuild/bazel-gazelle/pull/1546) #### New Contributors - [@​connyay](https://togithub.com/connyay) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1507](https://togithub.com/bazelbuild/bazel-gazelle/pull/1507) - [@​mark-thm](https://togithub.com/mark-thm) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1518](https://togithub.com/bazelbuild/bazel-gazelle/pull/1518) - [@​Preston4tw](https://togithub.com/Preston4tw) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1483](https://togithub.com/bazelbuild/bazel-gazelle/pull/1483) - [@​kriswuollett](https://togithub.com/kriswuollett) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1453](https://togithub.com/bazelbuild/bazel-gazelle/pull/1453) - [@​purkhusid](https://togithub.com/purkhusid) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1508](https://togithub.com/bazelbuild/bazel-gazelle/pull/1508) - [@​birunts](https://togithub.com/birunts) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1524](https://togithub.com/bazelbuild/bazel-gazelle/pull/1524) - [@​sgavinio](https://togithub.com/sgavinio) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1539](https://togithub.com/bazelbuild/bazel-gazelle/pull/1539) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.30.0...v0.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuNCIsInVwZGF0ZWRJblZlciI6IjM1LjEwMi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
May 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.30.0` -> `v0.31.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.30.0...v0.31.0) #### What's Changed - feat: allow passing GIT_CONFIG_COUNT and it's related configs by [@​manuelnaranjo](https://togithub.com/manuelnaranjo) in [https://github.com/bazelbuild/bazel-gazelle/pull/1462](https://togithub.com/bazelbuild/bazel-gazelle/pull/1462) - feat(bzlmod): add `module_override` tag to allow patching in go_deps by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1500](https://togithub.com/bazelbuild/bazel-gazelle/pull/1500) - fix typo `build_proto_file_mode` in message by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1504](https://togithub.com/bazelbuild/bazel-gazelle/pull/1504) - fix: support running within a dir named workspace by [@​jbedard](https://togithub.com/jbedard) in [https://github.com/bazelbuild/bazel-gazelle/pull/1498](https://togithub.com/bazelbuild/bazel-gazelle/pull/1498) - fix: check for gazelle command before adding -repo_config flag by [@​cgrindel](https://togithub.com/cgrindel) in [https://github.com/bazelbuild/bazel-gazelle/pull/1501](https://togithub.com/bazelbuild/bazel-gazelle/pull/1501) - language/go: Infer prefix from go.mod by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1497](https://togithub.com/bazelbuild/bazel-gazelle/pull/1497) - don't overwrite directives by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1503](https://togithub.com/bazelbuild/bazel-gazelle/pull/1503) - Support Bzlmod for gazelle itself by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1509](https://togithub.com/bazelbuild/bazel-gazelle/pull/1509) - language/go: Add windows arm64 as a known platform. by [@​connyay](https://togithub.com/connyay) in [https://github.com/bazelbuild/bazel-gazelle/pull/1507](https://togithub.com/bazelbuild/bazel-gazelle/pull/1507) - Adding lifecycle manager by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1475](https://togithub.com/bazelbuild/bazel-gazelle/pull/1475) - Disable protobuf generation for more modules by [@​seh](https://togithub.com/seh) in [https://github.com/bazelbuild/bazel-gazelle/pull/1514](https://togithub.com/bazelbuild/bazel-gazelle/pull/1514) - Support '~' in label repo by [@​mark-thm](https://togithub.com/mark-thm) in [https://github.com/bazelbuild/bazel-gazelle/pull/1518](https://togithub.com/bazelbuild/bazel-gazelle/pull/1518) - language/go: Handle `unix` build tag. by [@​connyay](https://togithub.com/connyay) in [https://github.com/bazelbuild/bazel-gazelle/pull/1512](https://togithub.com/bazelbuild/bazel-gazelle/pull/1512) - Pass data arg through to sh_binary if defined by [@​Preston4tw](https://togithub.com/Preston4tw) in [https://github.com/bazelbuild/bazel-gazelle/pull/1483](https://togithub.com/bazelbuild/bazel-gazelle/pull/1483) - remove circular override hack by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/bazel-gazelle/pull/1515](https://togithub.com/bazelbuild/bazel-gazelle/pull/1515) - Add major version suffix download example by [@​kriswuollett](https://togithub.com/kriswuollett) in [https://github.com/bazelbuild/bazel-gazelle/pull/1453](https://togithub.com/bazelbuild/bazel-gazelle/pull/1453) - Relax parsing of labels by [@​purkhusid](https://togithub.com/purkhusid) in [https://github.com/bazelbuild/bazel-gazelle/pull/1508](https://togithub.com/bazelbuild/bazel-gazelle/pull/1508) - bzlmod: Add `build_file_generation` to `gazelle_override` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1522](https://togithub.com/bazelbuild/bazel-gazelle/pull/1522) - Fix incremental build of to bootstrap Gazelle by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1529](https://togithub.com/bazelbuild/bazel-gazelle/pull/1529) - Support macros/rules packed within bazel `struct` by [@​birunts](https://togithub.com/birunts) in [https://github.com/bazelbuild/bazel-gazelle/pull/1524](https://togithub.com/bazelbuild/bazel-gazelle/pull/1524) - Prefer non-proto over proto deps in external repos by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1537](https://togithub.com/bazelbuild/bazel-gazelle/pull/1537) - bzlmod: Return `extension_metadata` to automate `use_repo` fixes by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1511](https://togithub.com/bazelbuild/bazel-gazelle/pull/1511) - Fix `go:embed` failing to add `embedsrcs` for subdirectories named build by [@​sgavinio](https://togithub.com/sgavinio) in [https://github.com/bazelbuild/bazel-gazelle/pull/1539](https://togithub.com/bazelbuild/bazel-gazelle/pull/1539) - Remove support for godep and dep by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1541](https://togithub.com/bazelbuild/bazel-gazelle/pull/1541) - Avoid putting -repo_config after directories by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1544](https://togithub.com/bazelbuild/bazel-gazelle/pull/1544) - Dropping -args by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1546](https://togithub.com/bazelbuild/bazel-gazelle/pull/1546) #### New Contributors - [@​connyay](https://togithub.com/connyay) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1507](https://togithub.com/bazelbuild/bazel-gazelle/pull/1507) - [@​mark-thm](https://togithub.com/mark-thm) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1518](https://togithub.com/bazelbuild/bazel-gazelle/pull/1518) - [@​Preston4tw](https://togithub.com/Preston4tw) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1483](https://togithub.com/bazelbuild/bazel-gazelle/pull/1483) - [@​kriswuollett](https://togithub.com/kriswuollett) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1453](https://togithub.com/bazelbuild/bazel-gazelle/pull/1453) - [@​purkhusid](https://togithub.com/purkhusid) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1508](https://togithub.com/bazelbuild/bazel-gazelle/pull/1508) - [@​birunts](https://togithub.com/birunts) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1524](https://togithub.com/bazelbuild/bazel-gazelle/pull/1524) - [@​sgavinio](https://togithub.com/sgavinio) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1539](https://togithub.com/bazelbuild/bazel-gazelle/pull/1539) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.30.0...v0.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cgrindel/bazel-starlib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuNCIsInVwZGF0ZWRJblZlciI6IjM1LjEwMi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What package or component does this PR mostly affect?
internal/bzlmod/go_deps
What does this PR do? Why is it needed?
This adds a new
module_overridetag which allows a user to apply patches to ago_depsmodule.Which issues(s) does this PR fix?
Fixes #1499
Other notes for review
Added a test which applies a patch and asserts on contents from the patched repo.