language/go: Emit apparent repo name of rules_go in select keys #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constraint labels emitted as `select` keys now use the apparent name of the `rules_go` repository when using Bzlmod, with a fallback to `io_bazel_rules_go` if the `rules_go` module is not a declared `bazel_dep`.
fmeum
force-pushed
the
fix-platform-references
branch
from
3ea8cdf
to
4d8fc43
Compare
|
@jayconrod @tyler-french Could you take a look? |
jayconrod
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
LGTM. Definitely nice to get rid of that @io_bazel_.
What does migration look like? If someone is using io_bazel_rules_go from WORKSPACE, then switches to rules_go from bzlmod, will Gazelle figure that out correctly and fix the selects? Might be worth adding a test for that if it's not covered somewhere already.
|
Migration just works, added an integration test to verify this. |
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Jun 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | patch | `v0.31.0` -> `v0.31.1` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1) #### What's Changed - point sync.Once in walkConfig by [@​jmhodges](https://togithub.com/jmhodges) in [bazelbuild/bazel-gazelle#1532 - add copylock vet to nogo by [@​jmhodges](https://togithub.com/jmhodges) in [bazelbuild/bazel-gazelle#1534 - bzlmod: Remove deprecated override attributes on `go_deps.module` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1548 - Add default directives for github.com/envoyproxy/protoc-gen-validate by [@​mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1553 - cmd/gazelle: do not use the epoch as timestamp in diff output by [@​siddharthab](https://togithub.com/siddharthab) in [bazelbuild/bazel-gazelle#1552 - fileinfo: fix not detecting 'unix' files to be OS specific by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1554 - language/go: Emit apparent repo name of rules_go in select keys by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1555 - Let `bazel_dep`s replace Go deps by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1526 #### New Contributors - [@​mortenmj](https://togithub.com/mortenmj) made their first contribution in [bazelbuild/bazel-gazelle#1553 **Full Changelog**: bazelbuild/bazel-gazelle@v0.31.0...v0.31.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Jun 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | patch | `v0.31.0` -> `v0.31.1` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1) #### What's Changed - point sync.Once in walkConfig by [@​jmhodges](https://togithub.com/jmhodges) in [bazelbuild/bazel-gazelle#1532 - add copylock vet to nogo by [@​jmhodges](https://togithub.com/jmhodges) in [bazelbuild/bazel-gazelle#1534 - bzlmod: Remove deprecated override attributes on `go_deps.module` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1548 - Add default directives for github.com/envoyproxy/protoc-gen-validate by [@​mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1553 - cmd/gazelle: do not use the epoch as timestamp in diff output by [@​siddharthab](https://togithub.com/siddharthab) in [bazelbuild/bazel-gazelle#1552 - fileinfo: fix not detecting 'unix' files to be OS specific by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1554 - language/go: Emit apparent repo name of rules_go in select keys by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1555 - Let `bazel_dep`s replace Go deps by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1526 #### New Contributors - [@​mortenmj](https://togithub.com/mortenmj) made their first contribution in [bazelbuild/bazel-gazelle#1553 **Full Changelog**: bazelbuild/bazel-gazelle@v0.31.0...v0.31.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cgrindel/rules_swift_package_manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Jun 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | patch | `v0.31.0` -> `v0.31.1` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1) #### What's Changed - point sync.Once in walkConfig by [@​jmhodges](https://togithub.com/jmhodges) in [bazelbuild/bazel-gazelle#1532 - add copylock vet to nogo by [@​jmhodges](https://togithub.com/jmhodges) in [bazelbuild/bazel-gazelle#1534 - bzlmod: Remove deprecated override attributes on `go_deps.module` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1548 - Add default directives for github.com/envoyproxy/protoc-gen-validate by [@​mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1553 - cmd/gazelle: do not use the epoch as timestamp in diff output by [@​siddharthab](https://togithub.com/siddharthab) in [bazelbuild/bazel-gazelle#1552 - fileinfo: fix not detecting 'unix' files to be OS specific by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1554 - language/go: Emit apparent repo name of rules_go in select keys by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1555 - Let `bazel_dep`s replace Go deps by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1526 #### New Contributors - [@​mortenmj](https://togithub.com/mortenmj) made their first contribution in [bazelbuild/bazel-gazelle#1553 **Full Changelog**: bazelbuild/bazel-gazelle@v0.31.0...v0.31.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cgrindel/bazel-starlib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
language/go
What does this PR do? Why is it needed?
The constraint labels emitted as
selectkeys now use the apparent name of therules_gorepository when using Bzlmod, with a fallback toio_bazel_rules_goif therules_gomodule is not a declaredbazel_dep.