Stop resolving to @io_bazel_rules_go//proto/wkt #1567
Merged
+49
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Jul 2, 2023
achew22
approved these changes
Jul 2, 2023
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Jul 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.31.1` -> `v0.32.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.32.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.32.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.1...v0.32.0) Starting this release, Gazelle no longer resolves Go and proto imports of Google APIs to `@go_googleapis`. Instead, Go packages from Google APIs will be treated as regular Go packages, and resolve to `@org_golang_google_genproto`, which contains the pre-generated Go code, with its version determined by Go modules. For proto files importing Google APIs proto and generating Go code, users need to: 1. Add an `http_archive` rule to download Google APIs, e.g., <!----> http_archive( name = "googleapis", sha256 = "9d1a930e767c93c825398b8f8692eca3fe353b9aaadedfbcf1fca2282c85df88", strip_prefix = "googleapis-64926d52febbf298cb82a8f472ade4a3969ba922", urls = [ "https://github.com/googleapis/googleapis/archive/64926d52febbf298cb82a8f472ade4a3969ba922.zip", ], ) load("@​googleapis//:repository_rules.bzl", "switched_rules_by_language") switched_rules_by_language( name = "com_google_googleapis_imports", ) Note that the version of Google APIs archive needs to be compatible with the pre-generated code in `@org_golang_google_genproto`. 2. Resolve the proto manually. If Gazelle is being used, directives like the following need to be added to a parent directory of the proto files: <!----> ### gazelle:resolve proto proto google/rpc/status.proto @​googleapis//google/rpc:status_proto ### gazelle:resolve proto go google/rpc/status.proto @​org_golang_google_genproto//googleapis/rpc/status ### gazelle:resolve proto google/longrunning/operations.proto @​googleapis//google/longrunning:operations_proto ### gazelle:resolve proto go google/longrunning/operations.proto @​org_golang_google_genproto//googleapis/longrunning #### What's Changed - Decouple Google APIs by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1561](https://togithub.com/bazelbuild/bazel-gazelle/pull/1561) - resolve: Add a resolve_regexp directive by [@​DolceTriade](https://togithub.com/DolceTriade) in [https://github.com/bazelbuild/bazel-gazelle/pull/1542](https://togithub.com/bazelbuild/bazel-gazelle/pull/1542) - Remove module dependency on go_googleapis by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1563](https://togithub.com/bazelbuild/bazel-gazelle/pull/1563) - Testing on macOS arm64 by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1568](https://togithub.com/bazelbuild/bazel-gazelle/pull/1568) - Stop resolving to @​io_bazel_rules_go//proto/wkt by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1567](https://togithub.com/bazelbuild/bazel-gazelle/pull/1567) - Fix directive table in Readme file by [@​farhaven](https://togithub.com/farhaven) in [https://github.com/bazelbuild/bazel-gazelle/pull/1571](https://togithub.com/bazelbuild/bazel-gazelle/pull/1571) #### New Contributors - [@​DolceTriade](https://togithub.com/DolceTriade) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1542](https://togithub.com/bazelbuild/bazel-gazelle/pull/1542) - [@​farhaven](https://togithub.com/farhaven) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1571](https://togithub.com/bazelbuild/bazel-gazelle/pull/1571) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.31.1...v0.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jul 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.31.1` -> `v0.32.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.32.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.32.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.1...v0.32.0) Starting this release, Gazelle no longer resolves Go and proto imports of Google APIs to `@go_googleapis`. Instead, Go packages from Google APIs will be treated as regular Go packages, and resolve to `@org_golang_google_genproto`, which contains the pre-generated Go code, with its version determined by Go modules. For proto files importing Google APIs proto and generating Go code, users need to: 1. Add an `http_archive` rule to download Google APIs, e.g., <!----> http_archive( name = "googleapis", sha256 = "9d1a930e767c93c825398b8f8692eca3fe353b9aaadedfbcf1fca2282c85df88", strip_prefix = "googleapis-64926d52febbf298cb82a8f472ade4a3969ba922", urls = [ "https://github.com/googleapis/googleapis/archive/64926d52febbf298cb82a8f472ade4a3969ba922.zip", ], ) load("@​googleapis//:repository_rules.bzl", "switched_rules_by_language") switched_rules_by_language( name = "com_google_googleapis_imports", ) Note that the version of Google APIs archive needs to be compatible with the pre-generated code in `@org_golang_google_genproto`. 2. Resolve the proto manually. If Gazelle is being used, directives like the following need to be added to a parent directory of the proto files: <!----> ### gazelle:resolve proto proto google/rpc/status.proto @​googleapis//google/rpc:status_proto ### gazelle:resolve proto go google/rpc/status.proto @​org_golang_google_genproto//googleapis/rpc/status ### gazelle:resolve proto google/longrunning/operations.proto @​googleapis//google/longrunning:operations_proto ### gazelle:resolve proto go google/longrunning/operations.proto @​org_golang_google_genproto//googleapis/longrunning #### What's Changed - Decouple Google APIs by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1561](https://togithub.com/bazelbuild/bazel-gazelle/pull/1561) - resolve: Add a resolve_regexp directive by [@​DolceTriade](https://togithub.com/DolceTriade) in [https://github.com/bazelbuild/bazel-gazelle/pull/1542](https://togithub.com/bazelbuild/bazel-gazelle/pull/1542) - Remove module dependency on go_googleapis by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1563](https://togithub.com/bazelbuild/bazel-gazelle/pull/1563) - Testing on macOS arm64 by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1568](https://togithub.com/bazelbuild/bazel-gazelle/pull/1568) - Stop resolving to @​io_bazel_rules_go//proto/wkt by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1567](https://togithub.com/bazelbuild/bazel-gazelle/pull/1567) - Fix directive table in Readme file by [@​farhaven](https://togithub.com/farhaven) in [https://github.com/bazelbuild/bazel-gazelle/pull/1571](https://togithub.com/bazelbuild/bazel-gazelle/pull/1571) #### New Contributors - [@​DolceTriade](https://togithub.com/DolceTriade) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1542](https://togithub.com/bazelbuild/bazel-gazelle/pull/1542) - [@​farhaven](https://togithub.com/farhaven) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1571](https://togithub.com/bazelbuild/bazel-gazelle/pull/1571) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.31.1...v0.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cgrindel/rules_swift_package_manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Jul 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.31.1` -> `v0.32.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.32.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.32.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.1...v0.32.0) Starting this release, Gazelle no longer resolves Go and proto imports of Google APIs to `@go_googleapis`. Instead, Go packages from Google APIs will be treated as regular Go packages, and resolve to `@org_golang_google_genproto`, which contains the pre-generated Go code, with its version determined by Go modules. For proto files importing Google APIs proto and generating Go code, users need to: 1. Add an `http_archive` rule to download Google APIs, e.g., <!----> http_archive( name = "googleapis", sha256 = "9d1a930e767c93c825398b8f8692eca3fe353b9aaadedfbcf1fca2282c85df88", strip_prefix = "googleapis-64926d52febbf298cb82a8f472ade4a3969ba922", urls = [ "https://github.com/googleapis/googleapis/archive/64926d52febbf298cb82a8f472ade4a3969ba922.zip", ], ) load("@​googleapis//:repository_rules.bzl", "switched_rules_by_language") switched_rules_by_language( name = "com_google_googleapis_imports", ) Note that the version of Google APIs archive needs to be compatible with the pre-generated code in `@org_golang_google_genproto`. 2. Resolve the proto manually. If Gazelle is being used, directives like the following need to be added to a parent directory of the proto files: <!----> ### gazelle:resolve proto proto google/rpc/status.proto @​googleapis//google/rpc:status_proto ### gazelle:resolve proto go google/rpc/status.proto @​org_golang_google_genproto//googleapis/rpc/status ### gazelle:resolve proto google/longrunning/operations.proto @​googleapis//google/longrunning:operations_proto ### gazelle:resolve proto go google/longrunning/operations.proto @​org_golang_google_genproto//googleapis/longrunning #### What's Changed - Decouple Google APIs by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1561](https://togithub.com/bazelbuild/bazel-gazelle/pull/1561) - resolve: Add a resolve_regexp directive by [@​DolceTriade](https://togithub.com/DolceTriade) in [https://github.com/bazelbuild/bazel-gazelle/pull/1542](https://togithub.com/bazelbuild/bazel-gazelle/pull/1542) - Remove module dependency on go_googleapis by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1563](https://togithub.com/bazelbuild/bazel-gazelle/pull/1563) - Testing on macOS arm64 by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1568](https://togithub.com/bazelbuild/bazel-gazelle/pull/1568) - Stop resolving to @​io_bazel_rules_go//proto/wkt by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/bazel-gazelle/pull/1567](https://togithub.com/bazelbuild/bazel-gazelle/pull/1567) - Fix directive table in Readme file by [@​farhaven](https://togithub.com/farhaven) in [https://github.com/bazelbuild/bazel-gazelle/pull/1571](https://togithub.com/bazelbuild/bazel-gazelle/pull/1571) #### New Contributors - [@​DolceTriade](https://togithub.com/DolceTriade) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1542](https://togithub.com/bazelbuild/bazel-gazelle/pull/1542) - [@​farhaven](https://togithub.com/farhaven) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1571](https://togithub.com/bazelbuild/bazel-gazelle/pull/1571) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.31.1...v0.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cgrindel/bazel-starlib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bazel-contrib/rules_go#3595, @io_bazel_rules_go//proto/wkt only contains alias to pre-generated Go packages. Gazelle should resolve to those Go packages instead, so eventually we can remove the alias in @io_bazel_rules_go//proto/wkt