From add8e42934d1bf63ecf27f5439574383e74ef8fc Mon Sep 17 00:00:00 2001 From: Thomas Van Lenten Date: Tue, 18 Feb 2020 13:17:37 -0500 Subject: [PATCH] Run buildifier over the directory. (#235) Using the 1.0 release. ``` buildifier -r . ``` --- WORKSPACE | 6 +++--- internal_setup.bzl | 2 +- lib/new_sets.bzl | 1 + lib/unittest.bzl | 1 + 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index cb66c851..a6581ec6 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -4,10 +4,10 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe") maybe( - repo_rule = http_archive, name = "bazel_federation", - url = "https://github.com/bazelbuild/bazel-federation/releases/download/0.0.1/bazel_federation-0.0.1.tar.gz", + repo_rule = http_archive, sha256 = "506dfbfd74ade486ac077113f48d16835fdf6e343e1d4741552b450cfc2efb53", + url = "https://github.com/bazelbuild/bazel-federation/releases/download/0.0.1/bazel_federation-0.0.1.tar.gz", ) load("@bazel_federation//:repositories.bzl", "bazel_skylib_deps") @@ -31,8 +31,8 @@ load("//:internal_setup.bzl", "bazel_skylib_internal_setup") bazel_skylib_internal_setup() maybe( - repo_rule = http_archive, name = "rules_cc", + repo_rule = http_archive, sha256 = "b4b2a2078bdb7b8328d843e8de07d7c13c80e6c89e86a09d6c4b424cfd1aaa19", strip_prefix = "rules_cc-cb2dfba6746bfa3c3705185981f3109f0ae1b893", urls = [ diff --git a/internal_setup.bzl b/internal_setup.bzl index f79edd8a..e3189edc 100644 --- a/internal_setup.bzl +++ b/internal_setup.bzl @@ -15,4 +15,4 @@ """Setup function that must be invoked before running skylib tests.""" def bazel_skylib_internal_setup(): - pass # placeholder function for the federation + pass # placeholder function for the federation diff --git a/lib/new_sets.bzl b/lib/new_sets.bzl index 06e20584..332e9c53 100644 --- a/lib/new_sets.bzl +++ b/lib/new_sets.bzl @@ -36,6 +36,7 @@ def _make(elements = None): Returns: A set containing the passed in values. """ + # If you change the structure of a set, you need to also update the _is_set method # in types.bzl. elements = elements if elements else [] diff --git a/lib/unittest.bzl b/lib/unittest.bzl index 648b3130..2b9d267b 100644 --- a/lib/unittest.bzl +++ b/lib/unittest.bzl @@ -344,6 +344,7 @@ def _fail(env, msg): msg: The message to log describing the failure. """ full_msg = "In test %s: %s" % (env.ctx.attr._impl_name, msg) + # There isn't a better way to output the message in Starlark, so use print. # buildifier: disable=print print(full_msg)