Stop depending on rules_pkg through the federation. #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- while the federation code is in flux, this will mean less churn for skylib - rules_pkg is only needed by developers for making a distribution, so this won't impact users. - when we develop a new federation model, we can re-depend the right way.
fweikert
approved these changes
Jul 23, 2020
laurentlb
reviewed
Jul 23, 2020
There was a problem hiding this comment.
Should we update https://github.com/bazelbuild/bazel-skylib/blob/master/internal_deps.bzl?
I don't think so. From the point of view of skylib itself, that is currently a no-op. But if someone does include skylib via the federation and does not include python in their workspace they could conceivably have a problem. Leaving it this way should smoothly work when there is a federation update to the newer rules_pkg. The end user will be selecting the newer federation and will end up pulling in the newer rules_pkg to their workspace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bazelbuild/bazel-federation#117