Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_json/to_proto methods on structs are deprecated and will be removed #295

Merged

Conversation

tetromino
Copy link
Collaborator

We should not assume their existence.

Fixes #294

@tetromino tetromino requested a review from brandjon as a code owner April 29, 2021 15:17
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
Required to pass buildkite checks.
tetromino added 2 commits May 3, 2021 12:18

Verified

This commit was signed with the committer’s verified signature.
SeeminglyScience Patrick Meinecke
@tetromino tetromino merged commit 7b85903 into bazelbuild:main May 3, 2021
@tetromino tetromino deleted the incompatible_struct_has_no_methods branch May 3, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel 4.0.0 --incompatible_struct_has_no_methods
2 participants