Allow specifying additional aspects to tut #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, without this PR or other solution to #189 I am not able to conveniently unit test aspects. My workaround is to create an artificial rule that applies the aspect on its attribute, and collects the aspect outputs, but I'm still not able to make assertions about providers provided by the aspect on targets it's attached to. I'm happy to write up a longer problem description if ^ is not clear enough. |
|
@tetromino - would you mind taking a quick look? Thanks! |
|
@brandjon @tetromino would you be able to take a look here? 😅 🙏 |
tetromino
requested changes
Sep 7, 2021
To simulate this in a test I had to define a separate attribute with the aspect applied and ignore `target_under_test`, except because `target_under_test` is mandatory I had to set some value for it which was ignored. This may or may not fix bazelbuild#189 (I could see also wanting a `build_test`-like target which builds with an aspect - I'm not entirely sure what the scope of that issue was meant to be :))
illicitonion
force-pushed
the
extra_tut_aspects
branch
2 times, most recently
from
88c3f7d
to
a4aa41d
Compare
illicitonion
force-pushed
the
extra_tut_aspects
branch
from
a4aa41d
to
2363fa3
Compare
|
Added - thanks for the review @tetromino! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simulate this in a test I had to define a separate attribute with the
aspect applied and ignore
target_under_test, except becausetarget_under_testis mandatory I had to set some value for it whichwas ignored.
This may or may not fix
#189 (I could see also
wanting a
build_test-like target which builds with an aspect - I'm notentirely sure what the scope of that issue was meant to be :))