Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gazelle plugin to BCR #410

Closed
shs96c opened this issue Nov 8, 2022 · 3 comments
Closed

Add gazelle plugin to BCR #410

shs96c opened this issue Nov 8, 2022 · 3 comments
Assignees
Labels
P2 We'll consider to work on this in future. (Assignee optional) type: process

Comments

@shs96c
Copy link
Contributor

shs96c commented Nov 8, 2022

With #400 the gazelle plugin has now been added to the distribution, and it should be possible to ship it to BCR.

@tetromino
Copy link
Collaborator

tetromino commented Jan 17, 2023

After #400, I don't understand why the gazelle plugin belongs in this git repo:

  • skylib and the gazelle plugin now have separate bazel workspaces
  • gazelle plugin doesn't get built by bazel build //...
  • gazelle plugin doesn't get tested by bazel test //...
  • gazelle plugin depends only on skylib's public api
  • skylib does not depend on the gazelle plugin at all

But in any case, regardless of where the code lives, before making it releasable, we would need to add distro rules to generate the tarball. Equivalent of what we have already in distribution/BUILD for skylib.

@tetromino
Copy link
Collaborator

Distro rules to generate tarball will be added by #424

@tetromino tetromino self-assigned this Jan 17, 2023
@tetromino tetromino added P2 We'll consider to work on this in future. (Assignee optional) type: process labels Jan 17, 2023
@tetromino
Copy link
Collaborator

bazelbuild/bazel-central-registry#403 merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider to work on this in future. (Assignee optional) type: process
Projects
None yet
Development

No branches or pull requests

2 participants