Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--bes_backend doesn't support reading credentials from .netrc #15928

Closed
Yannic opened this issue Jul 20, 2022 · 1 comment
Closed

--bes_backend doesn't support reading credentials from .netrc #15928

Yannic opened this issue Jul 20, 2022 · 1 comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request untriaged

Comments

@Yannic
Copy link
Contributor

Yannic commented Jul 20, 2022

--remote_{downloader,cache,executor} all support reading credentials from .netrc: https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java;l=1098;drc=1bc1ce3e0d73c35047c29ef85e832db041e0f238

--bes_backend doesn't: https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/buildeventservice/BazelBuildEventServiceModule.java;l=79;drc=4cd266aa1dfa53d8c8de44f7895edcfd46f74725 calling into https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java;l=194;drc=4cd266aa1dfa53d8c8de44f7895edcfd46f74725

Found while working on #15856
@Yannic
Copy link
Contributor Author

Yannic commented Jul 20, 2022

cc @tjgq

@sgowroji sgowroji added type: feature request untriaged team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Jul 20, 2022
Yannic added a commit to EngFlow/bazel that referenced this issue Jul 20, 2022
@Yannic
Add netrc support to --bes_backend
e7e8562 
Progress on bazelbuild#15856

Fixes bazelbuild#15928
@Yannic Yannic mentioned this issue Jul 20, 2022
Closed
ckolli5 pushed a commit to ckolli5/bazel that referenced this issue Jul 22, 2022
@Yannic @ckolli5
Add netrc support to --bes_backend
69ee2d9 
Progress on bazelbuild#15856

Fixes bazelbuild#15928

Closes bazelbuild#15930.

PiperOrigin-RevId: 462379746
Change-Id: Ia7ae470bdcbd97c6cb42cc290c3891393ec9ce3a
@ckolli5 ckolli5 mentioned this issue Jul 22, 2022
Closed
tjgq pushed a commit to tjgq/bazel that referenced this issue Jul 25, 2022
@Yannic @tjgq
Add netrc support to --bes_backend
ee65573 
Progress on bazelbuild#15856

Fixes bazelbuild#15928

Closes bazelbuild#15930.

PiperOrigin-RevId: 462379746
Change-Id: Ia7ae470bdcbd97c6cb42cc290c3891393ec9ce3a
@tjgq tjgq mentioned this issue Jul 25, 2022
Merged
ckolli5 pushed a commit that referenced this issue Jul 25, 2022
@tjgq @Yannic
Add netrc support to --bes_backend (#15970)
96d23d3 
Progress on #15856

Fixes #15928

Closes #15930.

PiperOrigin-RevId: 462379746
Change-Id: Ia7ae470bdcbd97c6cb42cc290c3891393ec9ce3a

Co-authored-by: Yannic Bonenberger <yannic@engflow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add netrc support to --bes_backend EngFlow/bazel
2 participants
@Yannic @sgowroji