Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk #20816

Closed
bazel-io opened this issue Jan 9, 2024 · 5 comments
Closed

[7.2.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk #20816

bazel-io opened this issue Jan 9, 2024 · 5 comments
Milestone
7.2.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Jan 9, 2024

Forked from #20737
@bazel-io bazel-io added this to the 7.1.0 release blockers milestone Jan 9, 2024
@meteorcloudy meteorcloudy mentioned this issue Jan 11, 2024
Closed
@meteorcloudy meteorcloudy added the soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one. label Feb 8, 2024
@meteorcloudy
Copy link
Member

/cc @coeuvre adding this one as a soft release blocker, let me know if this should actually block the release!

@iancha1992 iancha1992 changed the title [7.1.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk [7.2.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk Feb 21, 2024
@iancha1992 iancha1992 changed the title [7.2.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk [7.1.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk Feb 22, 2024
@iancha1992 iancha1992 changed the title [7.1.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk [7.2.0] bazel build //X:all records target completion events in the BEP stream with file:// URIs, but sometimes doesn't write files to disk Mar 11, 2024
@keertk keertk removed the soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one. label Mar 25, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/skyframe/AspectCompletor.java
src/main/java/com/google/devtools/build/lib/skyframe/BUILD
src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
src/main/java/com/google/devtools/build/lib/skyframe/TargetCompletor.java

cc: @bazelbuild/triage

@coeuvre coeuvre mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 10, 2024
@coeuvre
[7.2.0] Ensure toplevel artifacts are downloaded before sending compl…
1102cce 
…etion ev… (#22318)

…ent.

Fixes #20737.

PiperOrigin-RevId: 632430888
Change-Id: I1f2e1034c73162e925e25eb57b31d6a32b30fad2

Closes #20816.
@iancha1992
Copy link
Member

Cherry-picked in #22318 by @coeuvre

@coeuvre
Copy link
Member

coeuvre commented May 13, 2024

Unfortunately, the change was reverted in HEAD because it broke one of our internal test (not sure why the test was not triggered by the presubmit though). I will work on fix and patch it on the 7.2.0.

@coeuvre coeuvre reopened this May 13, 2024
@coeuvre coeuvre mentioned this issue May 13, 2024
Merged
@iancha1992
Copy link
Member

iancha1992 commented May 13, 2024 •
edited

Will close this once #22348 is merged

github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@coeuvre
[7.2.0] Cherry-pick fix for an internal test failure that caused ... (#…
866914a 
…22348)

... the rollback of ee11240.

Closes #20816.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0 release blockers
Development

No branches or pull requests
5 participants
@meteorcloudy @coeuvre @bazel-io @keertk @iancha1992