Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not watch .netrc in read_netrc #22125

Closed
wants to merge 3 commits into from
Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 25, 2024

Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.

Fixes #22118

Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 25, 2024

@bazel-io fork 7.2.0

@fmeum fmeum requested a review from Wyverald April 25, 2024 15:14
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 25, 2024
@fmeum fmeum requested a review from meteorcloudy April 25, 2024 15:14
@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 25, 2024
@mortenmj
Copy link

@fmeum looks like tests are failing due to a lockfile being out of date.

(17:28:00) ERROR: Analysis of target '//src:test_repos' failed; build aborted: MODULE.bazel.lock is no longer up-to-date because: The implementation of the extension 'ModuleExtensionId{bzlFileLabel=//tools/test:extensions.bzl, extensionName=remote_coverage_tools_extension, isolationKey=Optional.empty}' or one of its transitive .bzl files has changed. Please run `bazel mod deps --lockfile_mode=update` to update your lockfile.

@fmeum
Copy link
Collaborator Author

fmeum commented Apr 25, 2024

Thanks @mortenmj, I updated the lockfiles.

@fmeum fmeum added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Apr 25, 2024
@mortenmj
Copy link

I would appreciate it if this could be considered for inclusion in 7.1.2

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 26, 2024
@fmeum fmeum deleted the 22118-netrc branch April 29, 2024 21:22
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 29, 2024

@bazel-io fork 7.1.2

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Apr 29, 2024
Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.

Fixes bazelbuild#22118

Closes bazelbuild#22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Apr 29, 2024
Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.

Fixes bazelbuild#22118

Closes bazelbuild#22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 30, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2024
Modifying auth information should not result in a repo rule being
reevaluated after a successful evaluation. This regressed in
a5376aa.

Fixes #22118

Closes #22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc

Commit
3fc76be

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@iancha1992
Copy link
Member

iancha1992 commented May 1, 2024

I would appreciate it if this could be considered for inclusion in 7.1.2

@mortenmj Looks like we are not planning for 7.1.2 anymore. But, this will be included in 7.2.0.
Thanks.

Wyverald pushed a commit that referenced this pull request May 6, 2024
Modifying auth information should not result in a repo rule being
reevaluated after a successful evaluation. This regressed in
a5376aa.

Fixes #22118

Closes #22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc

Commit
3fc76be

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Kila2 pushed a commit to Kila2/bazel that referenced this pull request May 13, 2024
Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.

Fixes bazelbuild#22118

Closes bazelbuild#22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository rules should not re-fetch when .netrc changes
5 participants