Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module extension isn't rerun when root MODULE.bazel's module is changed #22121

Closed
calebzulawski opened this issue Apr 25, 2024 · 0 comments
Closed
Assignees
Labels
P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@calebzulawski
Copy link

calebzulawski commented Apr 25, 2024

Description of the bug:

I have a module extension that reads the name and version of the root module. When the module values are changed, the module extension is not rerun. Adding return ctx.extension_metadata(reproducible = True) causes the extension to rerun.

cc @fmeum

Which category does this issue belong to?

External Dependency

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

Ubuntu

What is the output of bazel info release?

release 7.1.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Apr 25, 2024
@fmeum fmeum added P1 I'll work on this now. (Assignee required) and removed untriaged labels Apr 25, 2024
@fmeum fmeum assigned fmeum and unassigned sgowroji, iancha1992 and satyanandak Apr 25, 2024
Wyverald pushed a commit that referenced this issue May 7, 2024
Fixes #22121

Closes #22123.

PiperOrigin-RevId: 630277746
Change-Id: I893a69b0048e933554f515684c6ab1fdae541c0b
Wyverald pushed a commit that referenced this issue May 7, 2024
Fixes #22121

Closes #22123.

PiperOrigin-RevId: 630277746
Change-Id: I893a69b0048e933554f515684c6ab1fdae541c0b
github-merge-queue bot pushed a commit that referenced this issue May 7, 2024
#22282)

Fixes #22121

Closes #22123.

PiperOrigin-RevId: 630277746
Change-Id: I893a69b0048e933554f515684c6ab1fdae541c0b

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
Fixes bazelbuild#22121

Closes bazelbuild#22123.

PiperOrigin-RevId: 630277746
Change-Id: I893a69b0048e933554f515684c6ab1fdae541c0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants