Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec_properties for action ObjcLink does not effect #22314

Open
Kila2 opened this issue May 10, 2024 · 5 comments
Open

exec_properties for action ObjcLink does not effect #22314

Kila2 opened this issue May 10, 2024 · 5 comments
Labels
team-Configurability Issues for Configurability team type: bug untriaged

Comments

@Kila2
Copy link

Kila2 commented May 10, 2024

Description of the bug:

ios_application(
  ...
  exec_properties = {
    'key': 'value',
  }
)

for this rule. when set exec_properties. the remote execution server receive ObjcLink Action platform properties is empty CppLink platform properties is name: key value:value.

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

macos 13.6.4

What is the output of bazel info release?

bazel 7

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@brentleyjones
Copy link
Contributor

ios_application is defined in rules_apple (or rules_ios if you are using that), so this is probably best filed there.

@Kila2
Copy link
Author

Kila2 commented May 10, 2024

I'm sure this is a problem with Bazel. That's why I submitted it here.

@Kila2
Copy link
Author

Kila2 commented May 10, 2024

cc_common.link not getExecutionInfo from the exec_properties

@iancha1992
Copy link
Member

@Kila2
I think he meant here: https://github.com/bazelbuild/rules_apple/issues

@iancha1992 iancha1992 closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
@brentleyjones brentleyjones reopened this May 11, 2024
@Kila2
Copy link
Author

Kila2 commented May 13, 2024

I had add an option to support this feature. #22339

@iancha1992 iancha1992 added team-Configurability Issues for Configurability team team-Remote-Exec Issues and PRs for the Execution (Remote) team labels May 13, 2024
@oquenchil oquenchil removed the team-Remote-Exec Issues and PRs for the Execution (Remote) team label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability Issues for Configurability team type: bug untriaged
Projects
None yet
Development

No branches or pull requests

6 participants