Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pagination support for GitHub repos #241

Merged
merged 1 commit into from
May 21, 2021
Merged

Implement pagination support for GitHub repos #241

merged 1 commit into from
May 21, 2021

Conversation

fweikert
Copy link
Member

@fweikert fweikert commented May 5, 2021

Previously Bazelisk only read the first page of API responses.

Tested locally.

@fweikert
Implement pagination support for GitHub repos
49bfd71 
Previously Bazelisk only read the first page of API responses.

Tested locally.
@fweikert fweikert requested a review from philwo May 5, 2021 13:27
@fweikert fweikert marked this pull request as ready for review May 5, 2021 13:27
philwo
philwo approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@philwo philwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll LGTM this because it has tests and we need it, but we really need to reduce the complexity of our code base. It is very hard for me to understand what's going on and I don't actually feel comfortable that I'm not overlooking some bug here.

@philwo philwo merged commit 7af7115 into bazelbuild:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philwo philwo philwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fweikert @philwo