Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback to default releases.bazel.build url #431

Open
uberzzr opened this issue Mar 3, 2023 · 3 comments · May be fixed by uberzzr/bazelisk#1 or #433
Open

add fallback to default releases.bazel.build url #431

uberzzr opened this issue Mar 3, 2023 · 3 comments · May be fixed by uberzzr/bazelisk#1 or #433
Labels
P2 We'll consider working on this in future. (Assignee optional) type:bug Something isn't working

Comments

@uberzzr
Copy link

uberzzr commented Mar 3, 2023

When BAZELISK_BASE_URL is set and bazelisk fails to download Bazel from that URL, it would either throw an HTTPError or exit with 22. It should instead fallback to the default releases.bazel.build url

@ql-owo-lp
Copy link

I think the problem here is people use BAZELISK_BASE_URL because they forked the official repository and probably made some custom changes. Falling back to the official download is not what we expected.

@linzhp
Copy link
Contributor

linzhp commented Jul 7, 2023

Custom changes should not have the same version number as the official releases. So falling back to offical URLs only produces 404, which is expected.

@ql-owo-lp
Copy link

ql-owo-lp commented Jul 8, 2023

The assumption is wrong. In one project we maintain a version internally with our tweaks and we keep the internal version align with the main public version (e.g. 6.0.0).

Even if we do not align the version strictly, I think it's still reasonable people map their internal version to an arbitrary public version (e.g. internal 4.0.0 -> public 6.0.0). It's wrong to assume 404 will definitely happen.

@fweikert fweikert added type:bug Something isn't working P2 We'll consider working on this in future. (Assignee optional) labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants