New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildifier moves licenses() and distribs() from mainline to the package() declaration #1224

Open

aiuto opened this issue Dec 21, 2023 · 0 comments

Assignees

Contributor

aiuto commented Dec 21, 2023

We should not do this.

distribs() is no-op in bazel and being completely remove soon.
licenses() is a no-op in bazel, but is still widely seen, even if vestigial

Moving licenses to package() creates needless churn for reviewers, and can break existing tooling around finding licenses as a distinct tool

aiuto self-assigned this

aiuto mentioned this issue

Stop moving distribs from a function to the package. #1223

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment