New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move examples within bazelbuild/bazel into bazelbuild/examples repository #201
Comments
We should deprecate examples within bazelbuild/bazel in favor of bazelbuild/examples. We don't need an explanation. We just need to
|
Make sense, I just renamed the ticket to reflect this. If you already have another ticket for that we can close it. Should we create also one in bazelbuild/bazel to put everyone in sync or no need for that? |
There is already a cpp example in bazelbuild/examples. See: https://github.com/bazelbuild/examples/tree/main/cpp-tutorial The one in bazelbuild/examples is referred in https://bazel.build/start/cpp and it contains everything that this example contains. The only part missing in the example in bazelbuild/examples is to have a cc_test but this is covered in https://bazel.build/tutorials/cpp-use-cases#run-c-tests This would bring us closer to bazelbuild/examples#201
@aiuto did your opinion on this topic changed? Just asking because this was some time ago and before I create too many PR I would like to confirm that this is still the wish of the Bazel team. |
Bazel has two places with examples, bazelbuild/build and bazelbuild/examples. The first one is where the examples where originally but the second is where most of the examples are and where they should be long term. See: bazelbuild/examples#201
My opinion did not change, but it's not really my call. |
Ok thanks for the feedback. Whose call would be? It would be nice in order to have the example a bit more organized and less spread around. |
There is already a cpp example in bazelbuild/examples. See: https://github.com/bazelbuild/examples/tree/main/cpp-tutorial The one in bazelbuild/examples is referred in https://bazel.build/start/cpp and it contains everything that this example contains. The only part missing in the example in bazelbuild/examples is to have a cc_test but this is covered in https://bazel.build/tutorials/cpp-use-cases#run-c-tests This would bring us closer to bazelbuild/examples#201
@radvani13 is the product manager. @meteorcloudy leads the team that "delivers" Bazel, so that includes CI and the doc generation pipeline. We don't, sadly, have a dedicated documentation specialist for either the site or the examples. Our process has been to try to match incoming PRs to the the best subject matter reviewer. That is best suited for targeted additions rather than large restructurings. I recently rewrote the README to provide a cookbook style index into the examples. |
See: bazelbuild/examples#201 Closes #18581. PiperOrigin-RevId: 538469631 Change-Id: Ib0cfc6de5d9f0d2cc4fc045b47c2d8ce5a6b358e
See: bazelbuild/examples#201 Closes bazelbuild#18581. PiperOrigin-RevId: 538469631 Change-Id: Ib0cfc6de5d9f0d2cc4fc045b47c2d8ce5a6b358e
There is already a folder with bazel examples inside the bazel repository
https://github.com/bazelbuild/bazel/tree/master/examples
It would be good to add in the readme a reference to it and a small sentence explaining what is the difference or why they are separated. It would be nice in the future to have them in a single place and not have them splited between this repo and the bazelbuild/bazel repo.
The text was updated successfully, but these errors were encountered: