Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure expected when android_library has assets but no manifestattr defined #153

Open
nkoroste opened this issue Oct 2, 2023 · 0 comments

Comments

@nkoroste
Copy link
Contributor

nkoroste commented Oct 2, 2023

According to https://bazel.build/reference/be/android#android_binary.manifest:

The name of the Android manifest file, normally AndroidManifest.xml. Must be defined if resource_files or assets are defined.

The native android rules behave as expected however Starlark rules android will not fail if a manifest is missing but assets are present. See:

Bonus: we should also consider to introduce a new flag which if set will automatically create an empty manifest with the correct package rather than fail the build. This will closer match what Gradle does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant